Skip to content

feat(types): allow Service<T> to handle non-WorkerEntrypoint default export #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

feat(types): allow Service<T> to handle non-WorkerEntrypoint default export #4588

merged 3 commits into from
Jul 24, 2025

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Jul 22, 2025 •
edited
Loading

This PR updates Service<T> so that:

  • Returns Fetcher<T> when T is a WorkerEntrypoint class (Current behavior)
  • Returns Fetcher<InstanceType<T>> when T is a WorkerEntrypoint constructor
  • Returns never when T is a DurableObject or WorkflowEntrypoint
  • Returns Fetcher otherwise

This will enable wrangler types to infer the RPC methods from the default export with Service<typeof import("./worker").default> next.

Ref: cloudflare/workers-sdk#9897

@edmundhung edmundhung requested review from a team as code owners July 22, 2025 13:41
@github-actions
Copy link

github-actions bot commented Jul 22, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@edmundhung
Copy link
Member Author

edmundhung commented Jul 22, 2025

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jul 22, 2025
@github-actions
@edmundhung has signed the CLA in #4588
ec2bd08
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4588 will improve performances by 5.94%

Comparing edmundhung/improve-service-type (fb176e3) with main (40efdf6)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ request[RegExpBenchmark] 7.9 ms 7.5 ms +5.94%

@edmundhung edmundhung force-pushed the edmundhung/improve-service-type branch from 010f8c7 to 3c2da87 Compare July 22, 2025 17:08
edmundhung
edmundhung commented Jul 22, 2025
View reviewed changes
penalosa
penalosa reviewed Jul 23, 2025
View reviewed changes
@edmundhung edmundhung merged commit a86210a into main Jul 24, 2025
21 of 22 checks passed
@edmundhung edmundhung deleted the edmundhung/improve-service-type branch July 24, 2025 10:41
@edmundhung edmundhung mentioned this pull request Jul 28, 2025
Merged
6 tasks
joshthoward pushed a commit that referenced this pull request Aug 7, 2025
@edmundhung @joshthoward
feat(types): allow Service<T> to handle non-WorkerEntrypoint default …
d2dd7f9 
…export (#4588)

* feat(types): allow Service<T> to handle non-WorkerEntrypoint default export

* restrict types accepted

* unwrap condition to avoid Fetcher<never>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrishancock harrishancock harrishancock approved these changes

@penalosa penalosa penalosa approved these changes

@emily-shen emily-shen Awaiting requested review from emily-shen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edmundhung @harrishancock @penalosa