Skip to content

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Oct 22, 2025

No description provided.

@fhanau fhanau requested a review from mar-cf October 22, 2025 19:40
@fhanau fhanau requested review from a team as code owners October 22, 2025 19:40
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #5377 will not alter performance

Comparing felix/102025-stw-cleanup (4f33688) with main (48990e7)

Summary

✅ 33 untouched
⏩ 9 skipped1

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mar-cf
Copy link
Contributor

mar-cf commented Oct 28, 2025

LG. What are your thoughts behind what should be in and out of the tracing namespace?

@fhanau fhanau force-pushed the felix/102025-stw-cleanup branch from 1550a46 to 4f33688 Compare October 28, 2025 18:26
@fhanau
Copy link
Contributor Author

fhanau commented Oct 28, 2025

LG. What are your thoughts behind what should be in and out of the tracing namespace?

I didn't think about it too much – currently, we seem to have tail worker related code in the tracing namespace, but not the actual Span/SpanBuilder classes etc. I moved CompleteSpan into tracing since it is used as another RPC-able representation of a tail event, alongside other tail event types. This is more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants