Fix wrangler version secrets with Assets (#6693)

Author: GregBrimble

.changeset/lovely-pigs-bow.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: Persist Workers Assets when doing `wrangler versions secrets put/bulk`

packages/wrangler/src/__tests__/versions/secrets/bulk.test.ts

@@ -56,6 +56,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 
 		await runWrangler(
@@ -96,6 +97,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 
 		await runWrangler(`versions secret bulk --name script-name --x-versions`);
@@ -146,6 +148,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 
 		await runWrangler(`versions secret bulk --name script-name --x-versions`);

packages/wrangler/src/__tests__/versions/secrets/put.test.ts

@@ -40,6 +40,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 		await runWrangler(
 			"versions secret put NEW_SECRET --name script-name --x-versions"
@@ -67,6 +68,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 
 		mockStdIn.send(
@@ -107,6 +109,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 		});
 		await runWrangler("versions secret put NEW_SECRET --x-versions");
 
@@ -136,6 +139,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 
 			expect(metadata.annotations).not.toBeUndefined();
 			expect(
@@ -172,6 +176,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 
 			expect(metadata.annotations).not.toBeUndefined();
 			expect(
@@ -211,6 +216,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 
 			expect(metadata.annotations).not.toBeUndefined();
 			expect(
@@ -286,6 +292,7 @@ describe("versions secret put", () => {
 				"secret_key",
 				"secret_text",
 			]);
+			expect(metadata.keep_assets).toBeTruthy();
 
 			expect(metadata.annotations).not.toBeUndefined();
 			expect(

packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts

@@ -179,6 +179,7 @@ export function createWorkerUploadForm(worker: CfWorkerInit): FormData {
 		tail_consumers,
 		limits,
 		annotations,
+		keep_assets,
 		experimental_assets,
 		observability,
 	} = worker;
@@ -585,6 +586,7 @@ export function createWorkerUploadForm(worker: CfWorkerInit): FormData {
 		...(tail_consumers && { tail_consumers }),
 		...(limits && { limits }),
 		...(annotations && { annotations }),
+		...(keep_assets !== undefined && { keep_assets }),
 		...(experimental_assets && {
 			assets: {
 				jwt: experimental_assets.jwt,

packages/wrangler/src/deployment-bundle/worker.ts

@@ -355,6 +355,7 @@ export interface CfWorkerInit {
 	tail_consumers: CfTailConsumer[] | undefined;
 	limits: CfUserLimits | undefined;
 	annotations?: Record<string, string | undefined>;
+	keep_assets?: boolean | undefined;
 	experimental_assets: CfExperimentalAssets | undefined;
 	observability: Observability | undefined;
 }

packages/wrangler/src/versions/secrets/index.ts

@@ -209,6 +209,7 @@ export async function copyWorkerVersionWithNewSecrets({
 			"workers/message": versionMessage,
 			"workers/tag": versionTag,
 		},
+		keep_assets: true,
 		experimental_assets: undefined,
 		observability: scriptSettings.observability,
 	};