remove unnecessary new remoteBindings option from startWorker

Author: dario-piotrowicz

.changeset/tangy-steaks-boil.md

@@ -125,7 +125,7 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)("startWorker - remote bindings", () => {
 	});
 });
 
-it("doesn't connect to remote bindings when `remoteBindings` is set to `false`", async () => {
+it("doesn't connect to remote bindings when `remote` is set to `false`", async () => {
 	const helper = new WranglerE2ETestHelper();
 	await helper.seed(resolve(__dirname, "./workers"));
 	await helper.seed({
@@ -146,7 +146,7 @@ it("doesn't connect to remote bindings when `remoteBindings` is set to `false`",
 			dev: {
 				inspector: false,
 				server: { port: 0 },
-				remoteBindings: false,
+				remote: false,
 			},
 		});
 

packages/wrangler/e2e/remote-binding/start-worker-remote-bindings.test.ts

@@ -126,7 +126,6 @@ async function resolveDevConfig(
 	return {
 		auth,
 		remote: input.dev?.remote,
-		remoteBindings: input.dev?.remoteBindings ?? true,
 		server: {
 			hostname: input.dev?.server?.hostname || config.dev.ip,
 			port:
@@ -219,7 +218,7 @@ async function resolveBindings(
 			{
 				registry,
 				local: !input.dev?.remote,
-				remoteBindingsDisabled: input.dev?.remoteBindings === false,
+				remoteBindingsDisabled: input.dev?.remote === false,
 				name: config.name,
 			}
 		);

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -201,10 +201,7 @@ export class LocalRuntimeController extends RuntimeController {
 		try {
 			const configBundle = await convertToConfigBundle(data);
 
-			if (
-				data.config.dev.remoteBindings !== false &&
-				data.config.dev?.remote !== false
-			) {
+			if (data.config.dev?.remote !== false) {
 				// note: remote bindings use (transitively) LocalRuntimeController, so we need to import
 				// from the module lazily in order to avoid circular dependency issues
 				const { maybeStartOrUpdateRemoteProxySession, pickRemoteBindings } =

packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts

@@ -112,10 +112,7 @@ export class MultiworkerRuntimeController extends LocalRuntimeController {
 		try {
 			const configBundle = await convertToConfigBundle(data);
 
-			if (
-				data.config.dev.remoteBindings !== false &&
-				data.config.dev?.remote !== false
-			) {
+			if (data.config.dev?.remote !== false) {
 				// note: remote bindings use (transitively) LocalRuntimeController, so we need to import
 				// from the module lazily in order to avoid circular dependency issues
 				const { maybeStartOrUpdateRemoteProxySession } = await import(

packages/wrangler/src/api/startDevWorker/MultiworkerRuntimeController.ts

@@ -166,8 +166,6 @@ export interface StartDevWorkerInput {
 		 *   - undefined (default): Run your Worker's code locally, and any configured remote bindings remotely
 		 */
 		remote?: boolean | "minimal";
-		/** Whether remote bindings should be enabled */
-		remoteBindings?: boolean;
 		/** Cloudflare Account credentials. Can be provided upfront or as a function which will be called only when required. */
 		auth?: AsyncHook<CfAccount, [Pick<Config, "account_id">]>; // provide config.account_id as a hook param
 		/** Whether local storage (KV, Durable Objects, R2, D1, etc) is persisted. You can also specify the directory to persist data to. */

packages/wrangler/src/api/startDevWorker/types.ts

@@ -247,13 +247,12 @@ async function setupDevEnv(
 			},
 			dev: {
 				auth,
-				remote:
-					args.remote || (args.forceLocal || args.local ? false : undefined),
-				remoteBindings:
-					// Note: this ternary is a hack, just to make sure that `wrangler pages dev`
-					//       supports the AI binding (removing such support now would be a breaking change)
-					//       TODO: remove this hack in wrangler v5 (the following line should just be `args.local !== true,`)
-					args.enablePagesAssetsServiceBinding ? true : args.local !== true,
+				remote: args.enablePagesAssetsServiceBinding
+					? // When running `wrangler pages dev` we want `remote` to be `undefined` since that's the
+						// only supported mode for pages (note: we can't set it to `false` as that would break
+						// the AI binding)
+						undefined
+					: args.remote || (args.forceLocal || args.local ? false : undefined),
 				server: {
 					hostname: args.ip,
 					port: args.port,