use remoteBindings instead of localBindingsOnly

Author: dario-piotrowicz

.changeset/modern-foxes-dream.md

@@ -2,4 +2,4 @@
 "wrangler": minor
 ---
 
-add a `localBindingsOnly` option to `getPlatformProxy` to disable the remote aspect of remote bindings
+add a `remoteBindings` option to `getPlatformProxy` to allow the disabling of remote bindings

.changeset/tangy-steaks-boil.md

@@ -2,4 +2,4 @@
 "wrangler": minor
 ---
 
-Add `localBindingsOnly` option to `startWorker` to disable remote bindings
+Add a `remoteBindings` option to `startWorker` to disable remote bindings

fixtures/get-platform-proxy-remote-bindings/tests/local-bindings-only.test.ts renamed to fixtures/get-platform-proxy-remote-bindings/tests/remote-bindings-false.test.ts

@@ -3,15 +3,15 @@ import { getPlatformProxy } from "wrangler";
 import type { Ai } from "@cloudflare/workers-types/experimental";
 
 describe(
-	"getPlatformProxy - remote bindings with localBindingsOnly",
+	"getPlatformProxy - remote bindings with remoteBindings: false",
 	{ timeout: 50_000 },
 	() => {
 		test("getPlatformProxy works with remote bindings", async () => {
 			const { env, dispose } = await getPlatformProxy<{
 				AI: Ai;
 			}>({
-				configPath: "./wrangler.local-bindings-only.jsonc",
-				localBindingsOnly: true,
+				configPath: "./wrangler.remote-bindings-false.jsonc",
+				remoteBindings: false,
 			});
 
 			await expect(

fixtures/get-platform-proxy-remote-bindings/wrangler.local-bindings-only.jsonc renamed to fixtures/get-platform-proxy-remote-bindings/wrangler.remote-bindings-false.jsonc

@@ -125,7 +125,7 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)("startWorker - remote bindings", () => {
 	});
 });
 
-it("doesn't connect to remote bindings when `localBindingsOnly` is set", async () => {
+it("doesn't connect to remote bindings when `remoteBindings` is set to `false`", async () => {
 	const helper = new WranglerE2ETestHelper();
 	await helper.seed(resolve(__dirname, "./workers"));
 	await helper.seed({
@@ -147,7 +147,7 @@ it("doesn't connect to remote bindings when `localBindingsOnly` is set", async (
 				dev: {
 					inspector: false,
 					server: { port: 0 },
-					localBindingsOnly: true,
+					remoteBindings: false,
 				},
 			});
 

packages/wrangler/e2e/remote-binding/start-worker-remote-bindings.test.ts

@@ -86,10 +86,9 @@ export type GetPlatformProxyOptions = {
 	 */
 	persist?: boolean | { path: string };
 	/**
-	 * Wether only local bindings should be used. This effectively disables the remote aspect of remote bindings
-	 * (exactly as if their `remote` configuration was changed from `true` to `false`)
+	 * Wether remote bindings should be enabled or not (defaults to `true`)
 	 */
-	localBindingsOnly?: boolean;
+	remoteBindings?: boolean;
 };
 
 /**
@@ -143,7 +142,7 @@ export async function getPlatformProxy<
 	});
 
 	let remoteProxySession: RemoteProxySession | undefined = undefined;
-	if (config.configPath && !options.localBindingsOnly) {
+	if (config.configPath && !options.remoteBindings) {
 		remoteProxySession = (
 			(await maybeStartOrUpdateRemoteProxySession({
 				path: config.configPath,

packages/wrangler/src/api/integrations/platform/index.ts

@@ -126,7 +126,7 @@ async function resolveDevConfig(
 	return {
 		auth,
 		remote: input.dev?.remote,
-		localBindingsOnly: input.dev?.localBindingsOnly,
+		remoteBindings: input.dev?.remoteBindings ?? true,
 		server: {
 			hostname: input.dev?.server?.hostname || config.dev.ip,
 			port:
@@ -219,7 +219,7 @@ async function resolveBindings(
 			{
 				registry,
 				local: !input.dev?.remote,
-				localBindingsOnly: !!input.dev?.localBindingsOnly,
+				remoteBindingsDisabled: input.dev?.remoteBindings === false,
 				name: config.name,
 			}
 		);

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -202,7 +202,7 @@ export class LocalRuntimeController extends RuntimeController {
 			const configBundle = await convertToConfigBundle(data);
 
 			if (
-				!data.config.dev.localBindingsOnly &&
+				data.config.dev.remoteBindings !== false &&
 				data.config.dev?.remote !== false
 			) {
 				// note: remote bindings use (transitively) LocalRuntimeController, so we need to import

packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts

@@ -113,7 +113,7 @@ export class MultiworkerRuntimeController extends LocalRuntimeController {
 			const configBundle = await convertToConfigBundle(data);
 
 			if (
-				!data.config.dev.localBindingsOnly &&
+				data.config.dev.remoteBindings !== false &&
 				data.config.dev?.remote !== false
 			) {
 				// note: remote bindings use (transitively) LocalRuntimeController, so we need to import

packages/wrangler/src/api/startDevWorker/MultiworkerRuntimeController.ts

@@ -166,8 +166,8 @@ export interface StartDevWorkerInput {
 		 *   - undefined (default): Run your Worker's code locally, and any configured remote bindings remotely
 		 */
 		remote?: boolean | "minimal";
-		/** Whether only local bindings (no remote ones) should be used during local development */
-		localBindingsOnly?: boolean;
+		/** Whether remote bindings should be enabled */
+		remoteBindings?: boolean;
 		/** Cloudflare Account credentials. Can be provided upfront or as a function which will be called only when required. */
 		auth?: AsyncHook<CfAccount, [Pick<Config, "account_id">]>; // provide config.account_id as a hook param
 		/** Whether local storage (KV, Durable Objects, R2, D1, etc) is persisted. You can also specify the directory to persist data to. */