Skip to content

Commit 10f86fb

Browse files
feat: send metrics for command start/complete/error (#7267)
* stop collecting userId in telemetry Co-authored-by: emily-shen <[email protected]> * implement telemetry collection * infer errorType based on the constructor name * implement common event properties * log common event properties Co-authored-by: Edmund Hung <[email protected]> * respect metric enabled/disabled * remove dispatcher.identify * include SPARROW_SOURCE_KEY in PR pre-release build * fix tests * ensure debug log covers the request failed message * replace SPARROW_SOURCE_KEY regardless whethe env exists --------- Co-authored-by: Edmund Hung <[email protected]> Co-authored-by: emily-shen <[email protected]> Co-authored-by: Edmund Hung <[email protected]>
1 parent 61acb66 commit 10f86fb

File tree

12 files changed

+312
-326
lines changed

12 files changed

+312
-326
lines changed

.github/workflows/create-pullrequest-prerelease.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ jobs:
5757
run: node .github/prereleases/2-build-pack-upload.mjs
5858
env:
5959
NODE_ENV: "production"
60+
# this is the "test/staging" key for sparrow analytics
61+
SPARROW_SOURCE_KEY: "5adf183f94b3436ba78d67f506965998"
6062
ALGOLIA_APP_ID: ${{ secrets.ALGOLIA_APP_ID }}
6163
ALGOLIA_PUBLIC_KEY: ${{ secrets.ALGOLIA_PUBLIC_KEY }}
6264
SENTRY_DSN: "https://[email protected]/583"

packages/wrangler/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@
8686
"selfsigned": "^2.0.1",
8787
"source-map": "^0.6.1",
8888
"unenv": "npm:[email protected]",
89+
"which-pm-runs": "^1.1.0",
8990
"workerd": "1.20241106.1",
9091
"xxhash-wasm": "^1.0.1"
9192
},
@@ -115,6 +116,7 @@
115116
"@types/shell-quote": "^1.7.2",
116117
"@types/signal-exit": "^3.0.1",
117118
"@types/supports-color": "^8.1.1",
119+
"@types/which-pm-runs": "^1.0.0",
118120
"@types/ws": "^8.5.7",
119121
"@types/yargs": "^17.0.22",
120122
"@vitest/ui": "catalog:default",

packages/wrangler/scripts/bundle.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ async function buildMain(flags: BuildFlags = {}) {
4444
__RELATIVE_PACKAGE_PATH__,
4545
"import.meta.url": "import_meta_url",
4646
"process.env.NODE_ENV": `'${process.env.NODE_ENV || "production"}'`,
47-
...(process.env.SPARROW_SOURCE_KEY
48-
? { SPARROW_SOURCE_KEY: `"${process.env.SPARROW_SOURCE_KEY}"` }
49-
: {}),
47+
"process.env.SPARROW_SOURCE_KEY": JSON.stringify(
48+
process.env.SPARROW_SOURCE_KEY ?? ""
49+
),
5050
...(process.env.ALGOLIA_APP_ID
5151
? { ALGOLIA_APP_ID: `"${process.env.ALGOLIA_APP_ID}"` }
5252
: {}),

0 commit comments

Comments
 (0)