Skip to content

Commit 1549390

Browse files
committed
add comment about applyBeforeValidation
1 parent 781b5f3 commit 1549390

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/wrangler/src/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -703,6 +703,8 @@ export async function main(argv: string[]): Promise<void> {
703703
command = `wrangler ${args._.join(" ")}`;
704704
metricsArgs = args;
705705
addBreadcrumb(command);
706+
// NB despite 'applyBeforeValidation = true', this runs *after* yargs 'validates' options,
707+
// e.g. if a required arg is missing, yargs will error out before we send any events :/
706708
void dispatcher?.sendNewEvent("wrangler command started", {
707709
command,
708710
args,

0 commit comments

Comments
 (0)