fix: make sure users can change inspector port when running vite dev (#8786)

* [vite-plugin] fix: make sure users can change inspector port when running vite dev

currently when a user starts a dev server with `vite dev` the inspector
port that the Cloudflare plugin will use will always be the initial one,
even if the user sets a specific port in the plugin's options inside
the vite config file, the changes here make sure that such config updates
are instead actually reflected

* Update .changeset/cuddly-news-double.md

Co-authored-by: James Opstad <[email protected]>

---------

Co-authored-by: James Opstad <[email protected]>

Author: dario-piotrowicz

.changeset/cuddly-news-double.md

@@ -0,0 +1,7 @@
+---
+"@cloudflare/vite-plugin": patch
+---
+
+fix: make sure users can change inspector port when running vite dev
+
+Ensure that the inspector port is updated if the user modifies it in the Vite config while the dev server is running.

packages/vite-plugin-cloudflare/src/index.ts

@@ -334,12 +334,12 @@ export function cloudflare(pluginConfig: PluginConfig = {}): vite.Plugin[] {
 					"Unexpected error: No Vite HTTP server"
 				);
 
-				if (!miniflare) {
-					const inputInspectorPort = await getInputInspectorPortOption(
-						pluginConfig,
-						viteDevServer
-					);
+				const inputInspectorPort = await getInputInspectorPortOption(
+					pluginConfig,
+					viteDevServer
+				);
 
+				if (!miniflare) {
 					miniflare = new Miniflare(
 						getDevMiniflareOptions(
 							resolvedPluginConfig,
@@ -348,14 +348,11 @@ export function cloudflare(pluginConfig: PluginConfig = {}): vite.Plugin[] {
 						)
 					);
 				} else {
-					const resolvedInspectorPort =
-						await getResolvedInspectorPort(pluginConfig);
-
 					await miniflare.setOptions(
 						getDevMiniflareOptions(
 							resolvedPluginConfig,
 							viteDevServer,
-							resolvedInspectorPort ?? false
+							inputInspectorPort
 						)
 					);
 				}
@@ -842,6 +839,19 @@ async function getInputInspectorPortOption(
 	pluginConfig: PluginConfig,
 	viteServer: vite.ViteDevServer | vite.PreviewServer
 ) {
+	if (
+		pluginConfig.inspectorPort === undefined ||
+		pluginConfig.inspectorPort === 0
+	) {
+		const resolvedInspectorPort = await getResolvedInspectorPort(pluginConfig);
+
+		if (resolvedInspectorPort !== null) {
+			// the user is not specifying an inspector port to use and we're already
+			// using one (this is a server restart) so let's just reuse that
+			return resolvedInspectorPort;
+		}
+	}
+
 	const inputInspectorPort =
 		pluginConfig.inspectorPort ??
 		(await getFirstAvailablePort(DEFAULT_INSPECTOR_PORT));