PIPE-391: Better error messages and client-side validation (#10833)

Some field validation has been moved to the client side for more immediate feedback.

```
./bin/wrangler.js pipelines setup

 ⛅️ wrangler 4.40.3
───────────────────
▲ [WARNING] 🚧 `wrangler pipelines setup` is an open-beta command. Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose

🚀 Welcome to Cloudflare Pipelines Setup!
This will guide you through creating a complete pipeline: stream → pipeline → sink

✔ What would you like to name your pipeline? … this-a-test

✘ [ERROR] Pipeline name must contain only letters, numbers, and underscores
```

Author: cmackenzie1

.changeset/some-spies-greet.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Validate Pipeline entity names in Wrangler config before sending to the API.

packages/wrangler/src/__tests__/pipelines.test.ts

@@ -1123,6 +1123,14 @@ describe("wrangler pipelines", () => {
 			);
 		});
 
+		it("should error when name contains invalid characters", async () => {
+			await expect(
+				runWrangler("pipelines streams create my-stream")
+			).rejects.toThrowErrorMatchingInlineSnapshot(
+				`[Error: stream name must contain only letters, numbers, and underscores]`
+			);
+		});
+
 		it("should create stream with default settings", async () => {
 			setIsTTY(true);
 			mockConfirm({
@@ -1564,6 +1572,16 @@ describe("wrangler pipelines", () => {
 			return requests;
 		}
 
+		it("should error when name contains invalid characters", async () => {
+			await expect(
+				runWrangler(
+					"pipelines sinks create my-sink --bucket my-bucket --type r2"
+				)
+			).rejects.toThrowErrorMatchingInlineSnapshot(
+				`[Error: sink name must contain only letters, numbers, and underscores]`
+			);
+		});
+
 		it("should error when type is missing", async () => {
 			await expect(
 				runWrangler("pipelines sinks create my_sink --bucket my-bucket")

packages/wrangler/src/pipelines/cli/setup.ts

@@ -16,6 +16,7 @@ import {
 } from "../client";
 import { SINK_DEFAULTS } from "../defaults";
 import { authorizeR2Bucket } from "../index";
+import { validateEntityName } from "../validate";
 import {
 	displayUsageExamples,
 	formatSchemaFieldsForTable,
@@ -91,11 +92,7 @@ async function setupPipelineNaming(
 		throw new UserError("Pipeline name is required");
 	}
 
-	if (!/^[a-zA-Z0-9_-]+$/.test(pipelineName)) {
-		throw new UserError(
-			"Pipeline name must contain only letters, numbers, hyphens, and underscores"
-		);
-	}
+	validateEntityName("pipeline", pipelineName);
 
 	const streamName = `${pipelineName}_stream`;
 	const sinkName = `${pipelineName}_sink`;

packages/wrangler/src/pipelines/cli/sinks/create.ts

@@ -6,6 +6,7 @@ import { requireAuth } from "../../../user";
 import { createSink } from "../../client";
 import { applyDefaultsToSink, SINK_DEFAULTS } from "../../defaults";
 import { authorizeR2Bucket } from "../../index";
+import { validateEntityName } from "../../validate";
 import { displaySinkConfiguration } from "./utils";
 import type { CreateSinkRequest, SinkFormat } from "../../types";
 
@@ -102,6 +103,8 @@ export const pipelinesSinksCreateCommand = createCommand({
 		},
 	},
 	validateArgs: (args) => {
+		validateEntityName("sink", args.sink);
+
 		const sinkType = parseSinkType(args.type);
 
 		if (!isValidR2BucketName(args.bucket)) {

packages/wrangler/src/pipelines/cli/streams/create.ts

@@ -6,6 +6,7 @@ import { logger } from "../../../logger";
 import { parseJSON } from "../../../parse";
 import { requireAuth } from "../../../user";
 import { createStream } from "../../client";
+import { validateEntityName } from "../../validate";
 import { displayStreamConfiguration } from "./utils";
 import type { CreateStreamRequest, SchemaField } from "../../types";
 
@@ -42,6 +43,9 @@ export const pipelinesStreamsCreateCommand = createCommand({
 			array: true,
 		},
 	},
+	validateArgs: (args) => {
+		validateEntityName("stream", args.stream);
+	},
 	async handler(args, { config }) {
 		await requireAuth(config);
 		const streamName = args.stream;

packages/wrangler/src/pipelines/validate.ts

@@ -1,5 +1,24 @@
-import { UserError } from "../errors";
+import { CommandLineArgsError, UserError } from "../errors";
 
+/**
+ * Validate entity name is used for Pipelines V1 API entities such as sources, sinks and pipelines.
+ * @param label the name of the entity to validate
+ * @param name the user provided name
+ */
+export function validateEntityName(label: string, name: string) {
+	if (!name.match(/^[a-zA-Z0-9_]+$/)) {
+		throw new CommandLineArgsError(
+			`${label} name must contain only letters, numbers, and underscores`
+		);
+	}
+}
+
+/**
+ * Validate name is used for legacy Pipelines. This validation should not be used for Pipelines V1 entities.
+ * @param label the name of the entity to validate
+ * @param name the user provided name
+ * @deprecated use validateEntityName instead
+ */
 export function validateName(label: string, name: string) {
 	if (!name.match(/^[a-zA-Z0-9-]+$/)) {
 		throw new UserError(`Must provide a valid ${label}`);