fix(vite-plugin): Support __ in additional module IDs (#9322)

* fix(vite-plugin): Anchor ADDITIONAL_MODULE_PATTERN regex to end of string

 ## Problem

There's a regex used to detect if certain files (wasm, .bin, .txt, .html) are being imported at runtime. The current regex looks like this:

```ts
const ADDITIONAL_MODULE_PATTERN = `__CLOUDFLARE_MODULE__(${ADDITIONAL_MODULE_TYPES.join("|")})__(.*?)__`;
```

This means if there are files with `__`s in them, those `__`s will get matched first, rather than the final `__` in the module pattern being matched on.

 ## Solution
Add a `$` to the end of the regex so, to anchor to the end of the string.

 ## Background context
`pnpm` stores files for packages in locations like this (note the `__`s), which uncovered this.

```
/path/to/project/node_modules/.pnpm/@prisma[email protected][email protected][email protected][email protected]/node_modules/@prisma/client/runtime/query_engine_bg.sqlite.wasm
```

* Make regex more resilient

* Add test to playground

* Revert fix to demonstrate failing test

* Revert "Revert fix to demonstrate failing test"

This reverts commit d7e57e0.

* Revert fix again so we can make sure test failing first

* Revert "Revert fix again so we can make sure test failing first"

This reverts commit 50093d4.

* Add changeset

Author: justinvdm

.changeset/neat-jokes-prove.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/vite-plugin": patch
+---
+
+Fix regex to correctly detect additional module imports with \_\_ in path

packages/vite-plugin-cloudflare/playground/additional-modules/__tests__/additional-modules.spec.ts

@@ -22,6 +22,11 @@ test("supports Text modules with a '.txt' extension", async () => {
 	expect(result).toBe("Example text content.\n");
 });
 
+test("supports modules with `__`s in the filename", async () => {
+	const result = await getTextResponse("/text2");
+	expect(result).toBe("Example text content 2");
+});
+
 test("supports CompiledWasm modules with a '.wasm' extension", async () => {
 	const result = await getJsonResponse("/wasm");
 	expect(result).toEqual({ result: 7 });

packages/vite-plugin-cloudflare/playground/additional-modules/src/index.ts

@@ -1,5 +1,6 @@
 import bin from "./modules/bin-example.bin";
 import html from "./modules/html-example.html";
+import text2 from "./modules/text__example__2.txt";
 import text from "./modules/text-example.txt";
 import wasm from "./modules/wasm-example.wasm";
 import init from "./modules/wasm-example.wasm?init";
@@ -21,6 +22,11 @@ export default {
 					headers: { "Content-Type": "text/plain" },
 				});
 			}
+			case "/text2": {
+				return new Response(text2, {
+					headers: { "Content-Type": "text/plain" },
+				});
+			}
 			case "/wasm": {
 				const instance = await WebAssembly.instantiate(wasm);
 				const result = instance.exports.add(3, 4);

packages/vite-plugin-cloudflare/playground/additional-modules/src/modules/text__example__2.txt

@@ -0,0 +1 @@
+Example text content 2

packages/vite-plugin-cloudflare/src/additional-modules.ts

@@ -26,5 +26,5 @@ export function matchAdditionalModule(source: string) {
 }
 
 export function createModuleReference(type: AdditionalModuleType, id: string) {
-	return `__CLOUDFLARE_MODULE__${type}__${id}__`;
+	return `__CLOUDFLARE_MODULE__${type}__${id}__CLOUDFLARE_MODULE__`;
 }

packages/vite-plugin-cloudflare/src/shared.ts

@@ -3,7 +3,7 @@ import { ADDITIONAL_MODULE_TYPES } from "./constants";
 export const UNKNOWN_HOST = "http://localhost";
 export const INIT_PATH = "/__vite_plugin_cloudflare_init__";
 
-const ADDITIONAL_MODULE_PATTERN = `__CLOUDFLARE_MODULE__(${ADDITIONAL_MODULE_TYPES.join("|")})__(.*?)__`;
+const ADDITIONAL_MODULE_PATTERN = `__CLOUDFLARE_MODULE__(${ADDITIONAL_MODULE_TYPES.join("|")})__(.*?)__CLOUDFLARE_MODULE__`;
 export const additionalModuleRE = new RegExp(ADDITIONAL_MODULE_PATTERN);
 export const additionalModuleGlobalRE = new RegExp(
 	ADDITIONAL_MODULE_PATTERN,