Continue createCommand migration with ✨AI✨ (#8966)

* wrangler init

* wrangler delete

* wrangler triggers

* halfway through wrangler queues

* complete queues migration

* wrangler d1

* wrangler ai

* hyperdrive & vectorize

* pages

* Fix AI code

* Create thirty-apples-invite.md

* more ai fixups

* mtls-certificate

* wrangler build

* wrangler pipelines

* wrangler dispatch-namespace

* fix check

* fix tests

* cleanup

* address comments

* fix lint

Author: penalosa

.changeset/thirty-apples-invite.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Internal refactor to use the `createCommand` utility

packages/wrangler/src/__tests__/d1/create.test.ts

@@ -32,11 +32,11 @@ describe("create", () => {
 		mockGetMemberships([
 			{ id: "IG-88", account: { id: "1701", name: "enterprise" } },
 		]);
-		await expect(
-			runWrangler("d1 create test --location sydney")
-		).rejects.toThrowError(
-			`Location 'sydney' invalid. Valid values are weur,eeur,apac,oc,wnam,enam`
-		);
+		await expect(runWrangler("d1 create test --location sydney")).rejects
+			.toThrowErrorMatchingInlineSnapshot(`
+			[Error: Invalid values:
+			  Argument: location, Given: "sydney", Choices: "weur", "eeur", "apac", "oc", "wnam", "enam"]
+		`);
 	});
 
 	it("should try send a request to the API for a valid input", async () => {

packages/wrangler/src/__tests__/d1/d1.test.ts

@@ -19,7 +19,7 @@ describe("d1", () => {
 			COMMANDS
 			  wrangler d1 list                List D1 databases
 			  wrangler d1 info <name>         Get information about a D1 database, including the current database size and state
-			  wrangler d1 insights <name>     Experimental command. Get information about the queries run on a D1 database.
+			  wrangler d1 insights <name>     Get information about the queries run on a D1 database. [experimental]
 			  wrangler d1 create <name>       Create D1 database
 			  wrangler d1 delete <name>       Delete D1 database
 			  wrangler d1 execute <database>  Execute a command or SQL file
@@ -55,7 +55,7 @@ describe("d1", () => {
 			COMMANDS
 			  wrangler d1 list                List D1 databases
 			  wrangler d1 info <name>         Get information about a D1 database, including the current database size and state
-			  wrangler d1 insights <name>     Experimental command. Get information about the queries run on a D1 database.
+			  wrangler d1 insights <name>     Get information about the queries run on a D1 database. [experimental]
 			  wrangler d1 create <name>       Create D1 database
 			  wrangler d1 delete <name>       Delete D1 database
 			  wrangler d1 execute <database>  Execute a command or SQL file
@@ -73,18 +73,11 @@ describe("d1", () => {
 	});
 
 	it("should show help when the migrations command is passed", async () => {
-		await expect(() => runWrangler("d1 migrations")).rejects.toThrow(
-			"Not enough non-option arguments: got 0, need at least 1"
-		);
-
-		expect(std.err).toMatchInlineSnapshot(`
-		"X [ERROR] Not enough non-option arguments: got 0, need at least 1
+		await runWrangler("d1 migrations");
+		await endEventLoop();
 
-		"
-	`);
 		expect(std.out).toMatchInlineSnapshot(`
-			"
-			wrangler d1 migrations
+			"wrangler d1 migrations
 
 			Interact with D1 migrations
 
@@ -103,18 +96,10 @@ describe("d1", () => {
 	});
 
 	it("should show help when the time travel command is passed", async () => {
-		await expect(() => runWrangler("d1 time-travel")).rejects.toThrow(
-			"Not enough non-option arguments: got 0, need at least 1"
-		);
-
-		expect(std.err).toMatchInlineSnapshot(`
-		"X [ERROR] Not enough non-option arguments: got 0, need at least 1
-
-		"
-	`);
+		await runWrangler("d1 time-travel");
+		await endEventLoop();
 		expect(std.out).toMatchInlineSnapshot(`
-			"
-			wrangler d1 time-travel
+			"wrangler d1 time-travel
 
 			Use Time Travel to restore, fork or copy a database at a specific point-in-time
 

packages/wrangler/src/__tests__/index.test.ts

@@ -44,7 +44,7 @@ describe("wrangler", () => {
 				  wrangler deployments            🚢 List and view the current and past deployments for your Worker
 				  wrangler rollback [version-id]  🔙 Rollback a deployment for a Worker
 				  wrangler versions               🫧  List, view, upload and deploy Versions of your Worker to Cloudflare
-				  wrangler triggers               🎯 Updates the triggers of your current deployment
+				  wrangler triggers               🎯 Updates the triggers of your current deployment [experimental]
 				  wrangler delete [script]        🗑  Delete a Worker from Cloudflare
 				  wrangler tail [worker]          🦚 Start a log tailing session for a Worker
 				  wrangler secret                 🤫 Generate a secret that can be referenced in a Worker
@@ -54,7 +54,7 @@ describe("wrangler", () => {
 				  wrangler queues                 🇶  Manage Workers Queues
 				  wrangler r2                     📦 Manage R2 buckets & objects
 				  wrangler d1                     🗄  Manage Workers D1 databases
-				  wrangler vectorize              🧮 Manage Vectorize indexes [open beta]
+				  wrangler vectorize              🧮 Manage Vectorize indexes
 				  wrangler hyperdrive             🚀 Manage Hyperdrive databases
 				  wrangler cert                   🪪 Manage client mTLS certificates and CA certificate chains used for secured connections [open-beta]
 				  wrangler pages                  ⚡️ Configure Cloudflare Pages
@@ -63,7 +63,7 @@ describe("wrangler", () => {
 				  wrangler dispatch-namespace     🏗️  Manage dispatch namespaces
 				  wrangler ai                     🤖 Manage AI models
 				  wrangler workflows              🔁 Manage Workflows
-				  wrangler pipelines              🚰 Manage Cloudflare Pipelines [open beta]
+				  wrangler pipelines              🚰 Manage Cloudflare Pipelines [open-beta]
 				  wrangler login                  🔓 Login to Cloudflare
 				  wrangler logout                 🚪 Logout from Cloudflare
 				  wrangler whoami                 🕵️  Retrieve your user information
@@ -104,7 +104,7 @@ describe("wrangler", () => {
 				  wrangler deployments            🚢 List and view the current and past deployments for your Worker
 				  wrangler rollback [version-id]  🔙 Rollback a deployment for a Worker
 				  wrangler versions               🫧  List, view, upload and deploy Versions of your Worker to Cloudflare
-				  wrangler triggers               🎯 Updates the triggers of your current deployment
+				  wrangler triggers               🎯 Updates the triggers of your current deployment [experimental]
 				  wrangler delete [script]        🗑  Delete a Worker from Cloudflare
 				  wrangler tail [worker]          🦚 Start a log tailing session for a Worker
 				  wrangler secret                 🤫 Generate a secret that can be referenced in a Worker
@@ -114,7 +114,7 @@ describe("wrangler", () => {
 				  wrangler queues                 🇶  Manage Workers Queues
 				  wrangler r2                     📦 Manage R2 buckets & objects
 				  wrangler d1                     🗄  Manage Workers D1 databases
-				  wrangler vectorize              🧮 Manage Vectorize indexes [open beta]
+				  wrangler vectorize              🧮 Manage Vectorize indexes
 				  wrangler hyperdrive             🚀 Manage Hyperdrive databases
 				  wrangler cert                   🪪 Manage client mTLS certificates and CA certificate chains used for secured connections [open-beta]
 				  wrangler pages                  ⚡️ Configure Cloudflare Pages
@@ -123,7 +123,7 @@ describe("wrangler", () => {
 				  wrangler dispatch-namespace     🏗️  Manage dispatch namespaces
 				  wrangler ai                     🤖 Manage AI models
 				  wrangler workflows              🔁 Manage Workflows
-				  wrangler pipelines              🚰 Manage Cloudflare Pipelines [open beta]
+				  wrangler pipelines              🚰 Manage Cloudflare Pipelines [open-beta]
 				  wrangler login                  🔓 Login to Cloudflare
 				  wrangler logout                 🚪 Logout from Cloudflare
 				  wrangler whoami                 🕵️  Retrieve your user information

packages/wrangler/src/__tests__/pages/deploy.test.ts

@@ -3055,7 +3055,7 @@ and that at least one include rule is provided.
 
 			await expect(runWrangler("pages deploy public --project-name=foo"))
 				.rejects.toThrow(`Deployment failed!
-Failed to publish your Function. Got error: Uncaught TypeError: a is not a function
+	Failed to publish your Function. Got error: Uncaught TypeError: a is not a function
   at functionsWorker-0.11031665179307093.js:41:1`);
 		});
 	});
@@ -4711,7 +4711,7 @@ and that at least one include rule is provided.
 
 			await expect(runWrangler("pages deploy public --project-name=foo"))
 				.rejects.toThrow(`Deployment failed!
-Failed to publish your Function. Got error: Uncaught TypeError: a is not a function
+	Failed to publish your Function. Got error: Uncaught TypeError: a is not a function
   at functionsWorker-0.11031665179307093.js:41:1`);
 		});
 	});

packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts

@@ -21,8 +21,7 @@ import type {
 import type { RequestInit } from "undici";
 import type WebSocket from "ws";
 
-// we want to include the banner to make sure it doesn't show up in the output when
-// when --format=json
+// we want to include the banner to make sure it doesn't show up in the output when --format=json
 vi.unmock("../../wrangler-banner");
 vi.mock("ws", async (importOriginal) => {
 	// eslint-disable-next-line @typescript-eslint/consistent-type-imports
@@ -52,6 +51,7 @@ vi.mock("ws", async (importOriginal) => {
 
 describe("pages deployment tail", () => {
 	runInTempDir();
+	const { setIsTTY } = useMockIsTTY();
 
 	let api: MockAPI;
 	afterEach(async () => {
@@ -65,11 +65,6 @@ describe("pages deployment tail", () => {
 	mockApiToken();
 	const std = mockConsoleMethods();
 
-	beforeEach(() => {
-		// Force the CLI to be "non-interactive" in test env
-		vi.stubEnv("CF_PAGES", "1");
-	});
-
 	/**
 	 * Interaction with the tailing API, including tail creation,
 	 * deletion, and connection.
@@ -417,8 +412,6 @@ describe("pages deployment tail", () => {
 	});
 
 	describe("printing", () => {
-		const { setIsTTY } = useMockIsTTY();
-
 		it("logs request messages in JSON format", async () => {
 			api = mockTailAPIs();
 			await runWrangler(

packages/wrangler/src/__tests__/pages/pages.test.ts

@@ -23,13 +23,13 @@ describe("pages", () => {
 			⚡️ Configure Cloudflare Pages
 
 			COMMANDS
-			  wrangler pages dev [directory] [-- command..]  Develop your full-stack Pages application locally
-			  wrangler pages functions                       Helpers related to Pages Functions
-			  wrangler pages project                         Interact with your Pages projects
-			  wrangler pages deployment                      Interact with the deployments of a project
-			  wrangler pages deploy [directory]              Deploy a directory of static assets as a Pages deployment  [aliases: publish]
-			  wrangler pages secret                          Generate a secret that can be referenced in a Pages project
-			  wrangler pages download                        Download settings from your project
+			  wrangler pages dev [directory] [command]  Develop your full-stack Pages application locally
+			  wrangler pages functions                  Helpers related to Pages Functions
+			  wrangler pages project                    Interact with your Pages projects
+			  wrangler pages deployment                 Interact with the deployments of a project
+			  wrangler pages deploy [directory]         Deploy a directory of static assets as a Pages deployment
+			  wrangler pages secret                     Generate a secret that can be referenced in a Pages project
+			  wrangler pages download                   Download settings from your project
 
 			GLOBAL FLAGS
 			      --cwd      Run as if Wrangler was started in the specified directory instead of the current working directory  [string]
@@ -43,7 +43,7 @@ describe("pages", () => {
 		await endEventLoop();
 
 		expect(std.out).toMatchInlineSnapshot(`
-			"wrangler pages dev [directory] [-- command..]
+			"wrangler pages dev [directory] [command]
 
 			Develop your full-stack Pages application locally
 
@@ -96,8 +96,8 @@ describe("pages", () => {
 
 			COMMANDS
 			  wrangler pages project list                   List your Cloudflare Pages projects
-			  wrangler pages project create [project-name]  Create a new Cloudflare Pages project
-			  wrangler pages project delete [project-name]  Delete a Cloudflare Pages project
+			  wrangler pages project create <project-name>  Create a new Cloudflare Pages project
+			  wrangler pages project delete <project-name>  Delete a Cloudflare Pages project
 
 			GLOBAL FLAGS
 			      --cwd      Run as if Wrangler was started in the specified directory instead of the current working directory  [string]
@@ -117,7 +117,9 @@ describe("pages", () => {
 
 			COMMANDS
 			  wrangler pages deployment list                List deployments in your Cloudflare Pages project
-			  wrangler pages deployment create [directory]  Publish a directory of static assets as a Pages deployment
+			  wrangler pages deployment create [directory]  Deploy a directory of static assets as a Pages deployment
+
+			                                                Alias for \\"wrangler pages deploy\\".
 			  wrangler pages deployment tail [deployment]   Start a tailing session for a project's deployment and livestream logs from your Functions
 
 			GLOBAL FLAGS
@@ -188,7 +190,7 @@ describe("pages", () => {
 			Download settings from your project
 
 			COMMANDS
-			  wrangler pages download config [projectName]  Experimental: Download your Pages project config as a Wrangler configuration file
+			  wrangler pages download config [projectName]  Download your Pages project config as a Wrangler configuration file [experimental]
 
 			GLOBAL FLAGS
 			      --cwd      Run as if Wrangler was started in the specified directory instead of the current working directory  [string]

packages/wrangler/src/__tests__/pages/project-delete.test.ts

@@ -67,7 +67,7 @@ describe("pages project delete", () => {
 		await expect(
 			runWrangler("pages project delete")
 		).rejects.toThrowErrorMatchingInlineSnapshot(
-			`[Error: Missing required argument: project-name]`
+			`[Error: Not enough non-option arguments: got 0, need at least 1]`
 		);
 	});
 

packages/wrangler/src/__tests__/pipelines.test.ts

@@ -274,14 +274,14 @@ describe("pipelines", () => {
 		expect(std.out).toMatchInlineSnapshot(`
 			"wrangler pipelines
 
-			🚰 Manage Cloudflare Pipelines [open beta]
+			🚰 Manage Cloudflare Pipelines [open-beta]
 
 			COMMANDS
-			  wrangler pipelines create <pipeline>  Create a new pipeline
-			  wrangler pipelines list               List all pipelines
-			  wrangler pipelines get <pipeline>     Get a pipeline's configuration
-			  wrangler pipelines update <pipeline>  Update a pipeline
-			  wrangler pipelines delete <pipeline>  Delete a pipeline
+			  wrangler pipelines create <pipeline>  Create a new pipeline [open-beta]
+			  wrangler pipelines list               List all pipelines [open-beta]
+			  wrangler pipelines get <pipeline>     Get a pipeline's configuration [open-beta]
+			  wrangler pipelines update <pipeline>  Update a pipeline [open-beta]
+			  wrangler pipelines delete <pipeline>  Delete a pipeline [open-beta]
 
 			GLOBAL FLAGS
 			  -c, --config   Path to Wrangler configuration file  [string]
@@ -301,10 +301,7 @@ describe("pipelines", () => {
 			expect(std.out).toMatchInlineSnapshot(`
 				"wrangler pipelines create <pipeline>
 
-				Create a new pipeline
-
-				POSITIONALS
-				  pipeline  The name of the new pipeline  [string] [required]
+				Create a new pipeline [open-beta]
 
 				Source settings
 				      --source             Space separated list of allowed sources. Options are 'http' or 'worker'  [array] [default: [\\"http\\",\\"worker\\"]]
@@ -326,6 +323,9 @@ describe("pipelines", () => {
 				Pipeline settings
 				      --shard-count  Number of shards for the pipeline. More shards handle higher request volume; fewer shards produce larger output files. Defaults to 2 if unset. Minimum: 1, Maximum: 15  [number]
 
+				POSITIONALS
+				  pipeline  The name of the new pipeline  [string] [required]
+
 				GLOBAL FLAGS
 				  -c, --config   Path to Wrangler configuration file  [string]
 				      --cwd      Run as if Wrangler was started in the specified directory instead of the current working directory  [string]