WC-4047 Respect keep_vars for versions upload (#10865)

Previously, versions uploaded was hardcoded to be false, but users
are confused that this behavior differs from deploy. Instead, we
should inherit the value from keep_vars, defaulting to false if
not provided. This aligns with the deploy behavior.

Author: WillTaylorDev

.changeset/lovely-spoons-rhyme.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Respect keep_vars for wrangler versions upload.

packages/wrangler/src/__tests__/versions/versions.upload.test.ts

@@ -765,6 +765,125 @@ describe("versions upload", () => {
 			expect(std.warn).toMatchInlineSnapshot(`""`);
 		});
 	});
+
+	describe("keep_vars", () => {
+		beforeEach(() => {
+			mockGetScript();
+			mockGetWorkerSubdomain({ enabled: true, previews_enabled: false });
+			writeWorkerSource();
+			setIsTTY(false);
+		});
+
+		test("should include plain_text and json in keep_bindings when keep_vars is true", async () => {
+			const mockUploadVersionCapture = captureRequestsFrom(
+				http.post(
+					`*/accounts/:accountId/workers/scripts/:scriptName/versions`,
+					async () => {
+						return HttpResponse.json(
+							createFetchResult({
+								id: "version-id",
+								startup_time_ms: 500,
+								metadata: {
+									has_preview: false,
+								},
+							})
+						);
+					}
+				)
+			)();
+
+			writeWranglerConfig({
+				name: "test-name",
+				main: "./index.js",
+				keep_vars: true,
+			});
+
+			await runWrangler("versions upload");
+
+			const request = mockUploadVersionCapture.requests[0];
+			const formBody = await request.clone().formData();
+			const metadata = JSON.parse(
+				await toString(formBody.get("metadata"))
+			) as WorkerMetadata;
+
+			expect(metadata.keep_bindings).toEqual(
+				expect.arrayContaining(["plain_text", "json"])
+			);
+		});
+
+		test("should not include plain_text and json in keep_bindings when keep_vars is false", async () => {
+			const mockUploadVersionCapture = captureRequestsFrom(
+				http.post(
+					`*/accounts/:accountId/workers/scripts/:scriptName/versions`,
+					async () => {
+						return HttpResponse.json(
+							createFetchResult({
+								id: "version-id",
+								startup_time_ms: 500,
+								metadata: {
+									has_preview: false,
+								},
+							})
+						);
+					}
+				)
+			)();
+
+			writeWranglerConfig({
+				name: "test-name",
+				main: "./index.js",
+				keep_vars: false,
+			});
+
+			await runWrangler("versions upload");
+
+			const request = mockUploadVersionCapture.requests[0];
+			const formBody = await request.clone().formData();
+			const metadata = JSON.parse(
+				await toString(formBody.get("metadata"))
+			) as WorkerMetadata;
+
+			expect(metadata.keep_bindings).not.toEqual(
+				expect.arrayContaining(["plain_text", "json"])
+			);
+		});
+
+		test("should not include plain_text and json in keep_bindings when keep_vars is not provided", async () => {
+			const mockUploadVersionCapture = captureRequestsFrom(
+				http.post(
+					`*/accounts/:accountId/workers/scripts/:scriptName/versions`,
+					async () => {
+						return HttpResponse.json(
+							createFetchResult({
+								id: "version-id",
+								startup_time_ms: 500,
+								metadata: {
+									has_preview: false,
+								},
+							})
+						);
+					}
+				)
+			)();
+
+			writeWranglerConfig({
+				name: "test-name",
+				main: "./index.js",
+			});
+
+			await runWrangler("versions upload");
+
+			const request = mockUploadVersionCapture.requests[0];
+			const formBody = await request.clone().formData();
+			const metadata = JSON.parse(
+				await toString(formBody.get("metadata"))
+			) as WorkerMetadata;
+
+			expect(metadata.keep_bindings).not.toEqual(
+				expect.arrayContaining(["plain_text", "json"])
+			);
+		});
+	});
 });
 
 const mockExecSync = vi.fn();

packages/wrangler/src/versions/upload.ts

@@ -383,7 +383,7 @@ export const versionsUploadCommand = createCommand({
 				outDir: args.outdir,
 				dryRun: args.dryRun,
 				noBundle: !(args.bundle ?? !config.no_bundle),
-				keepVars: false,
+				keepVars: config.keep_vars,
 				projectRoot: entry.projectRoot,
 				tag: args.tag,
 				message: args.message,
@@ -701,7 +701,7 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 				: undefined,
 			compatibility_date: compatibilityDate,
 			compatibility_flags: compatibilityFlags,
-			keepVars: false, // the wrangler.toml should be the source-of-truth for vars
+			keepVars: props.keepVars ?? false,
 			keepSecrets: true, // until wrangler.toml specifies secret bindings, we need to inherit from the previous Worker Version
 			placement,
 			tail_consumers: config.tail_consumers,