refactor: Always fill OpenAPI configuration in deployContainers, even in dry-run mode

Updated the deployContainers function to ensure that the OpenAPI configuration is filled regardless of the dryRun flag. This change is necessary for proper API access during container building. Additionally, modified the apply function to only execute when not in dry-run mode.

Author: hasip-timurtas

packages/wrangler/src/cloudchamber/deploy.ts

@@ -65,13 +65,14 @@ export async function deployContainers(
 		return;
 	}
 
-	if (!dryRun) {
-		await fillOpenAPIConfiguration(
-			config,
-			isNonInteractiveOrCI(),
-			containersScope
-		);
-	}
+	// Always fill OpenAPI configuration when containers are defined, even in dry-run mode
+	// because maybeBuildContainer needs to call loadAccount() which requires API access
+	await fillOpenAPIConfiguration(
+		config,
+		isNonInteractiveOrCI(),
+		containersScope
+	);
+
 	const pathToDocker = getDockerPath();
 	for (const container of config.containers) {
 		const version = await fetchVersion(
@@ -123,15 +124,18 @@ export async function deployContainers(
 		container.configuration.image = buildResult.image;
 		container.image = buildResult.image;
 
-		await apply(
-			{
-				skipDefaults: false,
-				json: true,
-				env,
-				imageUpdateRequired: buildResult.pushed,
-			},
-			configuration
-		);
+		// Only apply the configuration if not in dry-run mode
+		if (!dryRun) {
+			await apply(
+				{
+					skipDefaults: false,
+					json: true,
+					env,
+					imageUpdateRequired: buildResult.pushed,
+				},
+				configuration
+			);
+		}
 	}
 }
 

packages/wrangler/src/deploy/deploy.ts

@@ -11,8 +11,10 @@ import PQueue from "p-queue";
 import { Response } from "undici";
 import { syncAssets } from "../assets";
 import { fetchListResult, fetchResult } from "../cfetch";
+import { fillOpenAPIConfiguration } from "../cloudchamber/common";
 import { deployContainers, maybeBuildContainer } from "../cloudchamber/deploy";
 import { configFileName, formatConfigSnippet } from "../config";
+import { containersScope } from "../containers";
 import { getBindings, provisionBindings } from "../deployment-bundle/bindings";
 import { bundleWorker } from "../deployment-bundle/bundle";
 import { printBundleSize } from "../deployment-bundle/bundle-reporter";
@@ -30,6 +32,7 @@ import { getMigrationsToUpload } from "../durable";
 import { getDockerPath } from "../environment-variables/misc-variables";
 import { UserError } from "../errors";
 import { getFlag } from "../experimental-flags";
+import { isNonInteractiveOrCI } from "../is-interactive";
 import { logger } from "../logger";
 import { getMetricsUsageHeaders } from "../metrics";
 import { isNavigatorDefined } from "../navigator-user-agent";
@@ -786,6 +789,14 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 
 		if (props.dryRun) {
 			if (config.containers) {
+				// Set up OpenAPI configuration for container building in dry-run mode
+				// This is needed because maybeBuildContainer calls loadAccount() which requires API access
+				await fillOpenAPIConfiguration(
+					config,
+					isNonInteractiveOrCI(),
+					containersScope
+				);
+
 				for (const container of config.containers) {
 					await maybeBuildContainer(
 						container,