Skip to content

Commit 32cb120

Browse files
Temporarily skip Openapi C3 e2e tests (#9691)
* Temporarily skip Openapi C3 e2e tests Skipping in yarn due to node version resolution conflicts The Openapi C3 template depends on `chanfana`, which has a dependency on `yargs-parser`. The latest chanfana version (`2.8.1` at the time of this writting) has a dep on `yargs-parser@22` which requires a node version of `20.19.0` or higher. Our CI is currently using node version `20.11.1`. We currently can't bump the CI node version as other tests will fail, therefore skipping for now until we can properly fix * fix #2 * fix attempt #3 * fix attempt #4
1 parent 86eb8f9 commit 32cb120

File tree

2 files changed

+38
-42
lines changed

2 files changed

+38
-42
lines changed

packages/create-cloudflare/e2e-tests/cli.test.ts

Lines changed: 38 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -281,39 +281,47 @@ describe.skipIf(experimental || frameworkToTest || isQuarantineMode())(
281281
},
282282
);
283283

284-
test({ experimental }).skipIf(process.platform === "win32")(
285-
"Selecting template by description",
286-
async ({ logStream, project }) => {
287-
const { output } = await runC3(
288-
[project.path, "--no-deploy", "--git=false"],
289-
[
290-
{
291-
matcher: /What would you like to start with\?/,
292-
input: {
293-
type: "select",
294-
target: "Application Starter",
295-
assertDescriptionText:
296-
"Select from a range of starter applications using various Cloudflare products",
297-
},
284+
/*
285+
* Skipping in yarn due to node version resolution conflict
286+
* The Openapi C3 template depends on `chanfana`, which has a dependency
287+
* on `yargs-parser`. The latest chanfana version(`2.8.1` at the time
288+
* of this writting) has a dep on `yargs-parser@22` which requires a
289+
* node version of `20.19.0` or higher. Our CI is currently using node
290+
* version `20.11.1`. We currently can't bump the CI node version as other
291+
* tests will fail, therefore skipping for now until we can properly fix
292+
*/
293+
test({ experimental }).skipIf(
294+
process.platform === "win32" || pm === "yarn",
295+
)("Selecting template by description", async ({ logStream, project }) => {
296+
const { output } = await runC3(
297+
[project.path, "--no-deploy", "--git=false"],
298+
[
299+
{
300+
matcher: /What would you like to start with\?/,
301+
input: {
302+
type: "select",
303+
target: "Application Starter",
304+
assertDescriptionText:
305+
"Select from a range of starter applications using various Cloudflare products",
298306
},
299-
{
300-
matcher: /Which template would you like to use\?/,
301-
input: {
302-
type: "select",
303-
target: "API starter (OpenAPI compliant)",
304-
assertDescriptionText:
305-
"Get started building a basic API on Workers",
306-
},
307+
},
308+
{
309+
matcher: /Which template would you like to use\?/,
310+
input: {
311+
type: "select",
312+
target: "API starter (OpenAPI compliant)",
313+
assertDescriptionText:
314+
"Get started building a basic API on Workers",
307315
},
308-
],
309-
logStream,
310-
);
316+
},
317+
],
318+
logStream,
319+
);
311320

312-
expect(project.path).toExist();
313-
expect(output).toContain(`category Application Starter`);
314-
expect(output).toContain(`type API starter (OpenAPI compliant)`);
315-
},
316-
);
321+
expect(project.path).toExist();
322+
expect(output).toContain(`category Application Starter`);
323+
expect(output).toContain(`type API starter (OpenAPI compliant)`);
324+
});
317325

318326
test({ experimental }).skipIf(process.platform === "win32")(
319327
"Going back and forth between the category, type, framework and lang prompts",

packages/create-cloudflare/e2e-tests/workers.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -178,18 +178,6 @@ function getWorkerTests(opts: { experimental: boolean }): WorkerTestConfig[] {
178178
verifyDeploy: null,
179179
verifyPreview: null,
180180
},
181-
{
182-
template: "openapi",
183-
variants: [],
184-
verifyDeploy: {
185-
route: "/",
186-
expectedText: "SwaggerUI",
187-
},
188-
verifyPreview: {
189-
route: "/",
190-
expectedText: "SwaggerUI",
191-
},
192-
},
193181
];
194182
}
195183
}

0 commit comments

Comments
 (0)