feat: add config.keep_names option

Author: dario-piotrowicz

.changeset/long-mugs-pull.md

@@ -0,0 +1,25 @@
+---
+"wrangler": minor
+---
+
+feat: add `config.keep_names` option
+
+adds a new option so that developers can opt out of esbuild's `keep_names` option
+(see: https://esbuild.github.io/api/#keep-names) which wrangler otherwise sets
+to `true`
+
+this is something developers should not usually need to care about, but sometimes
+`keep_names` can create issues, in such cases they will be now able to set opt
+out of it
+
+example `wrangler.jsonc`:
+
+```json
+{
+	"name": "my-worker",
+	"main": "src/worker.ts",
+	"compatibility_flags": ["nodejs_compat"],
+
+	"minify": false
+}
+```

packages/wrangler/src/api/startDevWorker/BundlerController.ts

@@ -117,6 +117,7 @@ export class BundlerController extends Controller<BundlerControllerEventMap> {
 						jsxFragment: config.build.jsxFactory,
 						tsconfig: config.build.tsconfig,
 						minify: config.build.minify,
+						keepNames: config.build.keepNames ?? true,
 						nodejsCompatMode: config.build.nodejsCompatMode,
 						define: config.build.define,
 						checkFetch: shouldCheckFetch(
@@ -248,6 +249,7 @@ export class BundlerController extends Controller<BundlerControllerEventMap> {
 				rules: config.build.moduleRules,
 				tsconfig: config.build?.tsconfig,
 				minify: config.build?.minify,
+				keepNames: config.build?.keepNames ?? true,
 				nodejsCompatMode: config.build.nodejsCompatMode,
 				define: config.build.define,
 				alias: config.build.alias,

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -289,6 +289,7 @@ async function resolveConfig(
 			moduleRules: input.build?.moduleRules ?? getRules(config),
 
 			minify: input.build?.minify ?? config.minify,
+			keepNames: input.build?.keepNames ?? config.keep_names,
 			define: { ...config.define, ...input.build?.define },
 			custom: {
 				command: input.build?.custom?.command ?? config.build?.command,

packages/wrangler/src/api/startDevWorker/types.ts

@@ -107,6 +107,8 @@ export interface StartDevWorkerInput {
 		alias?: Record<string, string>;
 		/** Whether the bundled worker is minified. Only takes effect if bundle: true. */
 		minify?: boolean;
+		/** Whether to keep function names after JavaScript transpilations. */
+		keepNames?: boolean;
 		/** Options controlling a custom build step. */
 		custom?: {
 			/** Custom shell command to run before bundling. Runs even if bundle. */

packages/wrangler/src/config/config.ts

@@ -331,6 +331,7 @@ export const defaultWranglerConfig: Config = {
 	build: { command: undefined, watch_dir: "./src", cwd: undefined },
 	no_bundle: undefined,
 	minify: undefined,
+	keep_names: undefined,
 	dispatch_namespaces: [],
 	first_party_worker: undefined,
 	logfwdr: { bindings: [] },

packages/wrangler/src/config/environment.ts

@@ -306,6 +306,14 @@ interface EnvironmentInheritable {
 	 */
 	minify: boolean | undefined;
 
+	/**
+	 * Keep function names after javascript transpilations.
+	 *
+	 * @default {true}
+	 * @inheritable
+	 */
+	keep_names: boolean | undefined;
+
 	/**
 	 * Designates this Worker as an internal-only "first-party" Worker.
 	 *

packages/wrangler/src/config/validation.ts

@@ -1376,6 +1376,14 @@ function normalizeAndValidateEnvironment(
 			isBoolean,
 			undefined
 		),
+		keep_names: inheritable(
+			diagnostics,
+			topLevelEnv,
+			rawEnv,
+			"keep_names",
+			isBoolean,
+			undefined
+		),
 		first_party_worker: inheritable(
 			diagnostics,
 			topLevelEnv,

packages/wrangler/src/deploy/deploy.ts

@@ -558,6 +558,7 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 						jsxFragment,
 						tsconfig: props.tsconfig ?? config.tsconfig,
 						minify,
+						keepNames: config.keep_names ?? true,
 						sourcemap: uploadSourceMaps,
 						nodejsCompatMode,
 						define: { ...config.define, ...props.defines },

packages/wrangler/src/deployment-bundle/bundle.ts

@@ -120,6 +120,7 @@ export type BundleOptions = {
 	watch: boolean | undefined;
 	tsconfig: string | undefined;
 	minify: boolean | undefined;
+	keepNames: boolean;
 	nodejsCompatMode: NodeJSCompatMode | undefined;
 	define: Config["define"];
 	alias: Config["alias"];
@@ -155,6 +156,7 @@ export async function bundleWorker(
 		watch,
 		tsconfig,
 		minify,
+		keepNames,
 		nodejsCompatMode,
 		alias,
 		define,
@@ -370,7 +372,7 @@ export async function bundleWorker(
 		bundle,
 		absWorkingDir: entry.projectRoot,
 		outdir: destination,
-		keepNames: true,
+		keepNames,
 		entryNames: entryName || path.parse(entryFile).name,
 		...(isOutfile
 			? {

packages/wrangler/src/dev/use-esbuild.ts

@@ -42,6 +42,7 @@ export function runBuild(
 		rules,
 		tsconfig,
 		minify,
+		keepNames,
 		nodejsCompatMode,
 		define,
 		alias,
@@ -69,6 +70,7 @@ export function runBuild(
 		alias: Config["alias"];
 		tsconfig: string | undefined;
 		minify: boolean | undefined;
+		keepNames: boolean;
 		nodejsCompatMode: NodeJSCompatMode | undefined;
 		noBundle: boolean;
 		findAdditionalModules: boolean | undefined;
@@ -150,6 +152,7 @@ export function runBuild(
 						watch: true,
 						tsconfig,
 						minify,
+						keepNames,
 						nodejsCompatMode,
 						doBindings: durableObjects.bindings,
 						workflowBindings: workflows,