Skip to content

Commit 45497ab

Browse files
authored
Support image name without account ID (#9813)
* Support image name without account ID If a user uses an image in the Cloudflare managed registry they can specify the image name without including their full account ID. For example: image = "registry.cloudflare.com/hello/world:1.0" will now "just work", as Wrangler will automatically include their account ID in the appropriate location when creating the application. This matches the new behavior in the Dash, where we also omit the account ID in the image name. * Skip containers E2E tests when no auth available
1 parent a447d67 commit 45497ab

File tree

7 files changed

+162
-79
lines changed

7 files changed

+162
-79
lines changed

.changeset/fruity-pillows-peel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
Support container image names without account ID

packages/wrangler/e2e/containers.dev.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ const imageSource = ["pull", "build"];
1919
// We can only really run these tests on Linux, because we build our images for linux/amd64,
2020
// and github runners don't really support container virtualization in any sane way
2121
describe
22-
.skipIf(process.platform !== "linux" && process.env.CI === "true")
22+
.skipIf(
23+
!CLOUDFLARE_ACCOUNT_ID ||
24+
(process.platform !== "linux" && process.env.CI === "true")
25+
)
2326
.each(imageSource)(
2427
"containers local dev tests: %s",
2528
{ timeout: 90_000 },

0 commit comments

Comments
 (0)