test: fix e2e tests regarding recent preview_urls defaulting to false

Fixes existing tests, and adds a new test for `preview_urls = true`.

Author: danielrs

packages/wrangler/e2e/provision.test.ts

@@ -183,7 +183,6 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			env.R2 (inherited)                              R2 Bucket
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
-			Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
 			To deploy this version to production traffic use the command wrangler versions deploy
 			Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
 			Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"

packages/wrangler/e2e/versions.test.ts

@@ -69,7 +69,6 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			Worker Startup Time: (TIMINGS)
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
-			Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
 			To deploy this version to production traffic use the command wrangler versions deploy
 			Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
 			Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"
@@ -185,7 +184,6 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			Worker Startup Time: (TIMINGS)
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
-			Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
 			To deploy this version to production traffic use the command wrangler versions deploy
 			Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
 			Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"
@@ -589,7 +587,6 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			Worker Startup Time: (TIMINGS)
 			Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 			Worker Version ID: 00000000-0000-0000-0000-000000000000
-			Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
 			To deploy this version to production traffic use the command wrangler versions deploy
 			Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
 			Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"
@@ -631,7 +628,6 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 				Worker Startup Time: (TIMINGS)
 				Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
 				Worker Version ID: 00000000-0000-0000-0000-000000000000
-				Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
 				To deploy this version to production traffic use the command wrangler versions deploy
 				Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
 				Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"
@@ -652,6 +648,45 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			`);
 		});
 
+		it("should upload version of Worker with preview_urls enabled", async () => {
+			await helper.seed({
+				"wrangler.toml": dedent`
+					name = "${workerName}"
+					main = "src/index.ts"
+					compatibility_date = "2023-01-01"
+					preview_urls = true
+				`,
+				"src/index.ts": dedent`
+					export default {
+						fetch(request) {
+							return new Response("Hello World!")
+						}
+					}
+				`,
+				"package.json": dedent`
+					{
+						"name": "${workerName}",
+						"version": "0.0.0",
+						"private": true
+					}
+				`,
+			});
+			await helper.run("wrangler triggers deploy --force-subdomain-deploy");
+			const upload = await helper.run(
+				`wrangler versions upload --message "Upload via e2e test" --tag "e2e-version-with-preview"`
+			);
+			expect(normalize(upload.stdout)).toMatchInlineSnapshot(`
+				"Total Upload: xx KiB / gzip: xx KiB
+				Worker Startup Time: (TIMINGS)
+				Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
+				Worker Version ID: 00000000-0000-0000-0000-000000000000
+				Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
+				To deploy this version to production traffic use the command wrangler versions deploy
+				Changes to non-versioned settings (config properties 'logpush' or 'tail_consumers') take effect after your next deployment using the command wrangler versions deploy
+				Changes to triggers (routes, custom domains, cron schedules, etc) must be applied with the command wrangler triggers deploy"
+			`);
+		});
+
 		it("should include version preview url in output file", async () => {
 			const outputFile = path.join(helper.tmpPath, "output.jsonnd");
 			const upload = await helper.run(
@@ -677,10 +712,10 @@ describe.skipIf(!CLOUDFLARE_ACCOUNT_ID)(
 			const { stdout } = await helper.run(`wrangler delete`);
 
 			expect(normalize(stdout)).toMatchInlineSnapshot(`
-			"? Are you sure you want to delete tmp-e2e-worker-00000000-0000-0000-0000-000000000000? This action cannot be undone.
-			🤖 Using fallback value in non-interactive context: yes
-			Successfully deleted tmp-e2e-worker-00000000-0000-0000-0000-000000000000"
-		`);
+				"? Are you sure you want to delete tmp-e2e-worker-00000000-0000-0000-0000-000000000000? This action cannot be undone.
+				🤖 Using fallback value in non-interactive context: yes
+				Successfully deleted tmp-e2e-worker-00000000-0000-0000-0000-000000000000"
+			`);
 		});
 	}
 );