fix(wrangler): skip banner when using --json flag in wrangler pages deployment commands (#10822)

* fix(wrangler): wrangler pages deployment list --json should skip the banner

* refactor(wrangler): align printBanner setup on wrangler deployment commands

Author: edmundhung

.changeset/bumpy-schools-sniff.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+fix: skip banner when using `--json` flag in `wrangler pages deployment` commands

packages/wrangler/src/__tests__/pages/deployment-list.test.ts

@@ -8,6 +8,7 @@ import { runWrangler } from "./../helpers/run-wrangler";
 import type { Deployment } from "./../../pages/types";
 
 describe("pages deployment list", () => {
+	vi.unmock("../../wrangler-banner");
 	runInTempDir();
 	mockAccountId();
 	mockApiToken();
@@ -47,7 +48,10 @@ describe("pages deployment list", () => {
 
 		expect(requests.count).toBe(1);
 		expect(std.out).toMatchInlineSnapshot(`
-			"┌─┬─┬─┬─┬─┬─┬─┐
+			"
+			 ⛅️ wrangler x.x.x
+			──────────────────
+			┌─┬─┬─┬─┬─┬─┬─┐
 			│ Id │ Environment │ Branch │ Source │ Deployment │ Status │ Build │
 			├─┼─┼─┼─┼─┼─┼─┤
 			│ 87bbc8fe-16be-45cd-81e0-63d722e82cdf │ Preview │ main │ c764936 │ https://87bbc8fe.images.pages.dev │ 3 years ago │ https://dash.cloudflare.com/some-account-id/pages/view/images/87bbc8fe-16be-45cd-81e0-63d722e82cdf │

packages/wrangler/src/pages/deployments.ts

@@ -21,6 +21,7 @@ export const pagesDeploymentListCommand = createCommand({
 	},
 	behaviour: {
 		provideConfig: false,
+		printBanner: (args) => !args.json,
 	},
 	args: {
 		"project-name": {

packages/wrangler/src/versions/deployments/list.ts

@@ -31,7 +31,7 @@ export const deploymentsListCommand = createCommand({
 		},
 	},
 	behaviour: {
-		printBanner: false,
+		printBanner: (args) => !args.json,
 	},
 	handler: async function versionsDeploymentsListHandler(args, { config }) {
 		metrics.sendMetricsEvent(

packages/wrangler/src/versions/deployments/status.ts

@@ -6,7 +6,6 @@ import { UserError } from "../../errors";
 import * as metrics from "../../metrics";
 import { requireAuth } from "../../user";
 import formatLabelledValues from "../../utils/render-labelled-values";
-import { printWranglerBanner } from "../../wrangler-banner";
 import { fetchLatestDeployment, fetchVersions } from "../api";
 import { getDeploymentSource } from "./list";
 import type { VersionCache } from "../types";
@@ -32,13 +31,9 @@ export const deploymentsStatusCommand = createCommand({
 		},
 	},
 	behaviour: {
-		printBanner: false,
+		printBanner: (args) => !args.json,
 	},
 	handler: async function versionsDeploymentsStatusHandler(args, { config }) {
-		if (!args.json) {
-			await printWranglerBanner();
-		}
-
 		metrics.sendMetricsEvent(
 			"view latest versioned deployment",
 			{},