pr feedback

Author: emily-shen

fixtures/get-platform-proxy/wrangler_external_do.jsonc

@@ -1,13 +1,17 @@
 {
-	"name": "external_do",
+	"name": "external-do",
 	"main": "src/index.ts",
-	// external durable object - has script name
+	// external durable object = binding has script_name. This indicates that
+	// the DO is exported in a separate Worker called `do-worker`. For the
+	// purposes of testing, we don't need to set that up because
+	// getPlatformProxy would not be involved in running that Worker.
+
 	"durable_objects": {
 		"bindings": [
 			{
 				"class_name": "MyDurableObject",
 				"name": "MY_DURABLE_OBJECT",
-				"script_name": "internal-do",
+				"script_name": "do-worker",
 			},
 		],
 	},

fixtures/get-platform-proxy/wrangler_internal_do.jsonc

@@ -1,7 +1,11 @@
 {
-	"name": "internal_do",
+	"name": "internal-do",
 	"main": "src/index.ts",
-	// internal durable object
+	// Internal durable object = the binding does not specify a script name.
+	// This implies the DO is exported alongside this worker in `index.ts`,
+	// which it isn't actually. However we don't care about this here because
+	// getPlatformProxy will discard all user code anyway. We are simply making
+	// sure the warning shows up.
 	"durable_objects": {
 		"bindings": [
 			{

packages/wrangler/src/api/integrations/platform/index.ts

@@ -148,12 +148,12 @@ async function getMiniflareOptionsFromConfig(
 				${localBindings.map((b) => `- ${JSON.stringify(b)}`).join("\n")}
 				These will not work in local development, but they should work in production.
 
-				If you want to develop these locally, you can define your DO "externally" in another worker.
+				If you want to develop these locally, you can define your DO "externally" in another Worker.
 				To do this, create another Worker and Wrangler config file. Export your DO from there.
 				Then, set the \`script_name\` field in your original DO binding to equal the \`name\` field from your new external DO config.
 
 				You will be able to develop this locally by running:
-				npx wrangler dev -c path/to/original/wrangler.json -c path/to/external-do/wrangler.json
+				npx wrangler dev -c path/to/original/wrangler.jsonc -c path/to/external-do/wrangler.jsonc
 				`);
 		}
 	}

packages/wrangler/src/deployment-bundle/entry.ts

@@ -167,7 +167,10 @@ export function partitionDurableObjectBindings(config: Config): {
 	const localBindings: DurableObjectBindings = [];
 	const remoteBindings: DurableObjectBindings = [];
 	for (const binding of config.durable_objects.bindings) {
-		if (binding.script_name === undefined) {
+		if (
+			binding.script_name === undefined ||
+			binding.script_name === config.name
+		) {
 			localBindings.push(binding);
 		} else {
 			remoteBindings.push(binding);