Skip to content

Commit 5388447

Browse files
authored
Fix multiple request logging (#8883)
* fix multiple request logging * Create sour-islands-watch.md
1 parent 20992b4 commit 5388447

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

.changeset/sour-islands-watch.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"miniflare": patch
3+
"wrangler": patch
4+
---
5+
6+
fix: Only log requests to the Wrangler dev server once

packages/miniflare/src/workers/core/entry.worker.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ type Env = {
2828
[CoreBindings.DURABLE_OBJECT_NAMESPACE_PROXY]: DurableObjectNamespace;
2929
[CoreBindings.DATA_PROXY_SHARED_SECRET]?: ArrayBuffer;
3030
[CoreBindings.TRIGGER_HANDLERS]: boolean;
31+
[CoreBindings.LOG_REQUESTS]: boolean;
3132
} & {
3233
[K in `${typeof CoreBindings.SERVICE_USER_ROUTE_PREFIX}${string}`]:
3334
| Fetcher
@@ -421,7 +422,9 @@ export default <ExportedHandler<Env>>{
421422
}
422423
response = maybeInjectLiveReload(response, env, ctx);
423424
response = ensureAcceptableEncoding(clientAcceptEncoding, response);
424-
maybeLogRequest(request, response, env, ctx, startTime);
425+
if (env[CoreBindings.LOG_REQUESTS]) {
426+
maybeLogRequest(request, response, env, ctx, startTime);
427+
}
425428
return response;
426429
} catch (e: any) {
427430
return new Response(e?.stack ?? String(e), { status: 500 });

packages/wrangler/e2e/dev.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ describe.each([{ cmd: "wrangler dev" }, { cmd: "wrangler dev --remote" }])(
6969

7070
await worker.waitForReload();
7171

72+
// Regression test for issue where multiple request logs were being logged per request
73+
expect([...worker.currentOutput.matchAll(/GET /g)].length).toBe(1);
74+
7275
await expect(fetchText(url)).resolves.toMatchSnapshot();
7376
});
7477

0 commit comments

Comments
 (0)