Fix d1 info command showing read_replication: [object Object] (#9161)

* Fix d1 info command showing read_replication: [object Object]

Also add a fallback to unexpected fields to be JSON serialized at least.

* Create four-cherries-deny.md

Author: lambrospetrou

.changeset/four-cherries-deny.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix d1 info command showing read_replication: [object Object]

packages/wrangler/src/__tests__/d1/info.test.ts

@@ -79,10 +79,13 @@ describe("info", () => {
 							uuid: "d5b1d127-xxxx-xxxx-xxxx-cbc69f0a9e06",
 							name: "northwind",
 							created_at: "2023-05-23T08:33:54.590Z",
-							version: "beta",
+							version: "production",
 							num_tables: 13,
 							file_size: 33067008,
 							running_in_region: "WEUR",
+							read_replication: {
+								mode: "disabled",
+							},
 						},
 						success: true,
 						errors: [],
@@ -113,6 +116,9 @@ describe("info", () => {
 		  \\"created_at\\": \\"2023-05-23T08:33:54.590Z\\",
 		  \\"num_tables\\": 13,
 		  \\"running_in_region\\": \\"WEUR\\",
+		  \\"read_replication\\": {
+		    \\"mode\\": \\"disabled\\"
+		  },
 		  \\"database_size\\": 33067008,
 		  \\"read_queries_24h\\": 0,
 		  \\"write_queries_24h\\": 0,
@@ -131,10 +137,16 @@ describe("info", () => {
 							uuid: "d5b1d127-xxxx-xxxx-xxxx-cbc69f0a9e06",
 							name: "northwind",
 							created_at: "2023-05-23T08:33:54.590Z",
-							version: "beta",
+							version: "production",
 							num_tables: 13,
 							file_size: 33067008,
 							running_in_region: "WEUR",
+							read_replication: {
+								mode: "auto",
+							},
+							unexpected_object: {
+								iron: "man",
+							},
 						},
 						success: true,
 						errors: [],
@@ -164,27 +176,31 @@ describe("info", () => {
 			 ⛅️ wrangler x.x.x
 			------------------
 
-			┌───────────────────┬──────────────────────────────────────┐
-			│ DB                │ d5b1d127-xxxx-xxxx-xxxx-cbc69f0a9e06 │
-			├───────────────────┼──────────────────────────────────────┤
-			│ name              │ northwind                            │
-			├───────────────────┼──────────────────────────────────────┤
-			│ created_at        │ 2023-05-23T08:33:54.590Z             │
-			├───────────────────┼──────────────────────────────────────┤
-			│ num_tables        │ 13                                   │
-			├───────────────────┼──────────────────────────────────────┤
-			│ running_in_region │ WEUR                                 │
-			├───────────────────┼──────────────────────────────────────┤
-			│ database_size     │ 33.1 MB                              │
-			├───────────────────┼──────────────────────────────────────┤
-			│ read_queries_24h  │ 0                                    │
-			├───────────────────┼──────────────────────────────────────┤
-			│ write_queries_24h │ 0                                    │
-			├───────────────────┼──────────────────────────────────────┤
-			│ rows_read_24h     │ 0                                    │
-			├───────────────────┼──────────────────────────────────────┤
-			│ rows_written_24h  │ 0                                    │
-			└───────────────────┴──────────────────────────────────────┘"
+			┌───────────────────────┬──────────────────────────────────────┐
+			│ DB                    │ d5b1d127-xxxx-xxxx-xxxx-cbc69f0a9e06 │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ name                  │ northwind                            │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ created_at            │ 2023-05-23T08:33:54.590Z             │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ num_tables            │ 13                                   │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ running_in_region     │ WEUR                                 │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ unexpected_object     │ {\\"iron\\":\\"man\\"}                       │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ database_size         │ 33.1 MB                              │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ read_queries_24h      │ 0                                    │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ write_queries_24h     │ 0                                    │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ rows_read_24h         │ 0                                    │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ rows_written_24h      │ 0                                    │
+			├───────────────────────┼──────────────────────────────────────┤
+			│ read_replication.mode │ auto                                 │
+			└───────────────────────┴──────────────────────────────────────┘"
 		`);
 	});
 });

packages/wrangler/src/d1/info.ts

@@ -42,7 +42,7 @@ export const d1InfoCommand = createCommand({
 
 		const result = await getDatabaseInfoFromIdOrName(accountId, db.uuid);
 
-		const output: Record<string, string | number> = { ...result };
+		const output: Record<string, string | number | object> = { ...result };
 		if (output["file_size"]) {
 			output["database_size"] = output["file_size"];
 			delete output["file_size"];
@@ -118,6 +118,12 @@ export const d1InfoCommand = createCommand({
 		if (json) {
 			logger.log(JSON.stringify(output, null, 2));
 		} else {
+			// Selectively bring the nested read_replication info at the top level.
+			if (result.read_replication) {
+				output["read_replication.mode"] = result.read_replication.mode;
+				delete output["read_replication"];
+			}
+
 			// Snip off the "uuid" property from the response and use those as the header
 			const entries = Object.entries(output).filter(
 				// also remove any version that isn't "alpha"
@@ -134,6 +140,10 @@ export const d1InfoCommand = createCommand({
 					k === "rows_written_24h"
 				) {
 					value = v.toLocaleString();
+				} else if (typeof v === "object") {
+					// There shouldn't be any, but in the worst case we missed something
+					// or added a nested object in the response, serialize it instead of showing `[object Object]`.
+					value = JSON.stringify(v);
 				} else {
 					value = String(v);
 				}

packages/wrangler/src/d1/types.ts

@@ -18,10 +18,13 @@ export type DatabaseCreationResult = {
 export type DatabaseInfo = {
 	uuid: string;
 	name: string;
-	version: "alpha" | "beta";
+	version: "alpha" | "beta" | "production";
 	num_tables: number;
 	file_size: number;
 	running_in_region?: string;
+	read_replication?: {
+		mode: "auto" | "disabled";
+	};
 };
 
 export type Backup = {