[Workflows] Fix Workflows failure with redirect after creation (#10813)

* Add waitUntil of init promise of create call

* Add tests

Author: pombosilva

.changeset/polite-paths-raise.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/workflows-shared": patch
+---
+
+Workflows are now created if the Request gets redirected after creation

fixtures/workflow/src/index.ts

@@ -146,7 +146,15 @@ export default class extends WorkerEntrypoint<Env> {
 			handle = await this.env.WORKFLOW2.get(id);
 		} else if (url.pathname === "/get3") {
 			handle = await this.env.WORKFLOW3.get(id);
-		} else {
+		} else if (url.pathname === "/createWithRedirect") {
+			console.log("create with redirect called");
+			handle = await this.env.WORKFLOW.create();
+
+			return Response.redirect(
+				new URL(`/status?workflowName=${handle.id}`, url).toString(),
+				302
+			);
+		} else if (url.pathname === "/status") {
 			handle = await this.env.WORKFLOW.get(id);
 		}
 

fixtures/workflow/tests/index.test.ts

@@ -257,6 +257,23 @@ describe("Workflows", () => {
 		);
 	});
 
+	it("should create an instance after immediate redirect", async ({
+		expect,
+	}) => {
+		await expect(fetchJson(`http://${ip}:${port}/createWithRedirect`)).resolves
+			.toMatchInlineSnapshot(`
+			{
+			  "__LOCAL_DEV_STEP_OUTPUTS": [
+			    {
+			      "output": "First step result",
+			    },
+			  ],
+			  "output": null,
+			  "status": "running",
+			}
+		`);
+	});
+
 	it("should persist instances across lifetimes", async ({ expect }) => {
 		await fetchJson(`http://${ip}:${port}/create?workflowName=something`);
 

packages/workflows-shared/src/binding.ts

@@ -28,7 +28,7 @@ export class WorkflowBinding extends WorkerEntrypoint<Env> implements Workflow {
 		const stubId = this.env.ENGINE.idFromName(id);
 		const stub = this.env.ENGINE.get(stubId);
 
-		void stub.init(
+		const initPromise = stub.init(
 			0, // accountId: number,
 			{} as DatabaseWorkflow, // workflow: DatabaseWorkflow,
 			{} as DatabaseVersion, // version: DatabaseVersion,
@@ -40,6 +40,8 @@ export class WorkflowBinding extends WorkerEntrypoint<Env> implements Workflow {
 			}
 		);
 
+		this.ctx.waitUntil(initPromise);
+
 		const handle = new WorkflowHandle(id, stub);
 		return {
 			id: id,
@@ -55,7 +57,6 @@ export class WorkflowBinding extends WorkerEntrypoint<Env> implements Workflow {
 	public async get(id: string): Promise<WorkflowInstance> {
 		const engineStubId = this.env.ENGINE.idFromName(id);
 		const engineStub = this.env.ENGINE.get(engineStubId);
-
 		const handle = new WorkflowHandle(id, engineStub);
 
 		try {