Making explicit that if a body is sent to delete event notification config rules it is sent with an array of ruleIds

Author: jkoe-cf

.changeset/blue-bags-walk.md

@@ -0,0 +1,5 @@
+---
+"wrangler": minor
+---
+
+fix: making explicit to only send a body if there are rule ids specified in the config delete

packages/wrangler/src/__tests__/r2.test.ts

@@ -1039,6 +1039,7 @@ describe("r2", () => {
 							async ({ request, params }) => {
 								const { accountId } = params;
 								expect(accountId).toEqual("some-account-id");
+								expect(request.body).toBeNull();
 								expect(request.headers.get("authorization")).toEqual(
 									"Bearer some-api-token"
 								);
@@ -1100,6 +1101,9 @@ describe("r2", () => {
 							async ({ request, params }) => {
 								const { accountId } = params;
 								expect(accountId).toEqual("some-account-id");
+								expect(request.body).not.toBeNull();
+								const requestBody = await request.text();
+								expect(requestBody).toContain(`"ruleIds":["${ruleId}"]`);
 								expect(request.headers.get("authorization")).toEqual(
 									"Bearer some-api-token"
 								);

packages/wrangler/src/r2/helpers.ts

@@ -584,18 +584,24 @@ export async function deleteEventNotificationConfig(
 	logger.log(
 		`Disabling event notifications for "${bucketName}" to queue ${queueName}...`
 	);
-
-	const body: DeleteNotificationRequestBody =
-		ruleId !== undefined
-			? {
-					ruleIds: [ruleId],
-				}
-			: {};
-
-	return await fetchResult<null>(
-		`/accounts/${accountId}/event_notifications/r2/${bucketName}/configuration/queues/${queue.queue_id}`,
-		{ method: "DELETE", body: JSON.stringify(body), headers }
-	);
+	if (ruleId !== undefined) {
+		const body: DeleteNotificationRequestBody =
+			ruleId !== undefined
+				? {
+						ruleIds: [ruleId],
+					}
+				: {};
+
+		return await fetchResult<null>(
+			`/accounts/${accountId}/event_notifications/r2/${bucketName}/configuration/queues/${queue.queue_id}`,
+			{ method: "DELETE", body: JSON.stringify(body), headers }
+		);
+	} else {
+		return await fetchResult<null>(
+			`/accounts/${accountId}/event_notifications/r2/${bucketName}/configuration/queues/${queue.queue_id}`,
+			{ method: "DELETE", headers }
+		);
+	}
 }
 
 /**