Skip to content

Commit 5a2fbc5

Browse files
committed
refactor telemetry command
1 parent 4b0d169 commit 5a2fbc5

File tree

2 files changed

+41
-11
lines changed

2 files changed

+41
-11
lines changed

packages/wrangler/src/index.ts

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,13 @@ import {
7474
} from "./kv";
7575
import { logBuildFailure, logger, LOGGER_LEVELS } from "./logger";
7676
import { getMetricsDispatcher } from "./metrics";
77+
import {
78+
metricsAlias,
79+
telemetryDisableCommand,
80+
telemetryEnableCommand,
81+
telemetryNamespace,
82+
telemetryStatusCommand,
83+
} from "./metrics/commands";
7784
import { mTlsCertificateCommands } from "./mtls-certificate/cli";
7885
import { writeOutput } from "./output";
7986
import { pages } from "./pages";
@@ -932,6 +939,30 @@ export function createCLIParser(argv: string[]) {
932939
]);
933940
registry.registerNamespace("whoami");
934941

942+
registry.define([
943+
{
944+
command: "wrangler telemetry",
945+
definition: telemetryNamespace,
946+
},
947+
{
948+
command: "wrangler metrics",
949+
definition: metricsAlias,
950+
},
951+
{
952+
command: "wrangler telemetry disable",
953+
definition: telemetryDisableCommand,
954+
},
955+
{
956+
command: "wrangler telemetry enable",
957+
definition: telemetryEnableCommand,
958+
},
959+
{
960+
command: "wrangler telemetry status",
961+
definition: telemetryStatusCommand,
962+
},
963+
]);
964+
registry.registerNamespace("telemetry");
965+
935966
/******************************************************/
936967
/* DEPRECATED COMMANDS */
937968
/******************************************************/

packages/wrangler/src/metrics/commands.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import chalk from "chalk";
2-
import { defineAlias, defineCommand, defineNamespace } from "../core";
2+
import {
3+
createAlias,
4+
createCommand,
5+
createNamespace,
6+
} from "../core/create-command";
37
import { getWranglerSendMetricsFromEnv } from "../environment-variables/misc-variables";
48
import { logger } from "../logger";
59
import { readMetricsConfig, updateMetricsPermission } from "./metrics-config";
610

7-
defineNamespace({
8-
command: "wrangler telemetry",
11+
export const telemetryNamespace = createNamespace({
912
metadata: {
1013
description: "📈 Configure whether Wrangler collects telemetry",
1114
owner: "Workers: Authoring and Testing",
@@ -14,13 +17,11 @@ defineNamespace({
1417
},
1518
});
1619

17-
defineAlias({
18-
command: "wrangler metrics",
20+
export const metricsAlias = createAlias({
1921
aliasOf: "wrangler telemetry",
2022
});
2123

22-
defineCommand({
23-
command: "wrangler telemetry disable",
24+
export const telemetryDisableCommand = createCommand({
2425
metadata: {
2526
description: "Disable Wrangler telemetry collection",
2627
owner: "Workers: Authoring and Testing",
@@ -35,8 +36,7 @@ defineCommand({
3536
},
3637
});
3738

38-
defineCommand({
39-
command: "wrangler telemetry enable",
39+
export const telemetryEnableCommand = createCommand({
4040
metadata: {
4141
description: "Enable Wrangler telemetry collection",
4242
owner: "Workers: Authoring and Testing",
@@ -51,8 +51,7 @@ defineCommand({
5151
},
5252
});
5353

54-
defineCommand({
55-
command: "wrangler telemetry status",
54+
export const telemetryStatusCommand = createCommand({
5655
metadata: {
5756
description: "Check whether Wrangler telemetry collection is enabled",
5857
owner: "Workers: Authoring and Testing",

0 commit comments

Comments
 (0)