Skip to content

Commit 6291fa1

Browse files
authored
fix version metadata binding type in when generating env type (#8990)
* fix type of version metadata binding * changeset
1 parent 38ee9e4 commit 6291fa1

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

.changeset/plenty-beans-enjoy.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
fix: When generating Env types, set type of version metadata binding to `WorkerVersionMetadata`. This means it now correctly includes the `timestamp` field.

packages/wrangler/src/__tests__/type-generation.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ describe("generate types", () => {
443443
BROWSER_BINDING: Fetcher;
444444
AI_BINDING: Ai;
445445
IMAGES_BINDING: ImagesBinding;
446-
VERSION_METADATA_BINDING: { id: string; tag: string };
446+
VERSION_METADATA_BINDING: WorkerVersionMetadata;
447447
ASSETS_BINDING: Fetcher;
448448
PIPELINE: import(\\"cloudflare:pipelines\\").Pipeline<import(\\"cloudflare:pipelines\\").PipelineRecord>;
449449
}
@@ -533,7 +533,7 @@ describe("generate types", () => {
533533
BROWSER_BINDING: Fetcher;
534534
AI_BINDING: Ai;
535535
IMAGES_BINDING: ImagesBinding;
536-
VERSION_METADATA_BINDING: { id: string; tag: string };
536+
VERSION_METADATA_BINDING: WorkerVersionMetadata;
537537
ASSETS_BINDING: Fetcher;
538538
PIPELINE: import(\\"cloudflare:pipelines\\").Pipeline<import(\\"cloudflare:pipelines\\").PipelineRecord>;
539539
}

packages/wrangler/src/type-generation/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ export async function generateEnvTypes(
505505
if (configToDTS.version_metadata) {
506506
envTypeStructure.push([
507507
configToDTS.version_metadata.binding,
508-
"{ id: string; tag: string }",
508+
"WorkerVersionMetadata",
509509
]);
510510
}
511511

0 commit comments

Comments
 (0)