fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (#9583)

* fix(vite-plugin-cloudflare): allow unknown entrypoint on startup

* chore: simplify waitUntil implementation

* add changeset

* chore: add unknown named entrypoint service binding to vite worker playground

Author: edmundhung

.changeset/nine-facts-kneel.md

@@ -0,0 +1,7 @@
+---
+"@cloudflare/vite-plugin": patch
+---
+
+fix: avoid crashing on unknown service bindings at startup
+
+With Dev Registry support, the plugin no longer throws an assertion error during startup when a service binding references a named entrypoint from an unknown worker. Instead, an appropriate runtime error will be returned if the worker cannot be resolved.

fixtures/dev-registry/wrangler.module-worker.jsonc

@@ -20,6 +20,11 @@
 			"binding": "WORKER_ENTRYPOINT_B",
 			"service": "worker-entrypoint-b",
 		},
+		{
+			"binding": "NAMED_ENTRYPOINT",
+			"service": "unknown-worker",
+			"entrypoint": "UnknownEntrypoint",
+		},
 	],
 	"tail_consumers": [
 		{

packages/miniflare/test/test-shared/asserts.ts

@@ -63,33 +63,22 @@ export async function waitFor<T>(
 	}
 }
 
-export function waitUntil(
+export async function waitUntil(
 	t: ExecutionContext,
 	impl: (t: ExecutionContext) => Awaitable<void>,
-	timeout: number = 5000,
-	delay: number = 200
+	timeout: number = 5000
 ): Promise<void> {
-	return new Promise((resolve, reject) => {
-		const start = Date.now();
-		const interval = setInterval(async () => {
-			try {
-				const result = await t.try(impl);
+	const start = Date.now();
 
-				if (result.passed || Date.now() - start > timeout) {
-					clearInterval(interval);
-					try {
-						result.commit();
-						resolve();
-					} catch (ex) {
-						reject(ex);
-					}
-					return;
-				}
+	while (true) {
+		const result = await t.try(impl);
 
-				result.discard();
-			} catch {
-				// Ignore errors and keep waiting
-			}
-		}, delay);
-	});
+		if (result.passed || Date.now() - start > timeout) {
+			result.commit();
+			return;
+		}
+
+		result.discard();
+		await sleep(100);
+	}
 }

packages/vite-plugin-cloudflare/playground/worker/wrangler.jsonc

@@ -2,4 +2,11 @@
 	"name": "worker",
 	"main": "./src/index.ts",
 	"compatibility_date": "2024-12-30",
+	"services": [
+		{
+			"binding": "TEST_IF_VITE_CRASH_WITH_UNKNOWN_NAMED_ENTRYPOINT",
+			"service": "unknown-worker",
+			"entrypoint": "NamedEntrypoint",
+		},
+	],
 }

packages/vite-plugin-cloudflare/src/miniflare-options.ts

@@ -84,9 +84,10 @@ function getWorkerToWorkerEntrypointNamesMap(
 					value.name === kCurrentWorker ? worker.name : value.name;
 				const entrypointNames =
 					workerToWorkerEntrypointNamesMap.get(targetWorkerName);
-				assert(entrypointNames, missingWorkerErrorMessage(targetWorkerName));
 
-				entrypointNames.add(value.entrypoint);
+				if (entrypointNames) {
+					entrypointNames.add(value.entrypoint);
+				}
 			}
 		}
 	}