warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (#9573)

* remove dev_exposed_ports

* warn instead of erroring if no ports eposed

* fixups

Author: emily-shen

packages/miniflare/src/plugins/containers/service/index.ts

@@ -75,7 +75,7 @@ export class ContainerController {
 		if (output === "0" && process.platform !== "linux") {
 			throw new Error(
 				`The container "${imageTag.replace(MF_CONTAINER_PREFIX + "/", "")}" does not expose any ports.\n` +
-					"To develop containers locally on non-Linux platforms, you must expose any ports that you call with `getTCPPort() in your Dockerfile."
+					"To develop containers locally on non-Linux platforms, you must expose any ports that you call with `getTCPPort()` in your Dockerfile."
 			);
 		}
 	}

packages/wrangler/e2e/containers.dev.test.ts

@@ -119,24 +119,23 @@ describe.skipIf(process.platform !== "linux" && process.env.CI === "true")(
 				});
 			});
 			it.skipIf(process.platform === "linux")(
-				"errors in windows/macos if no ports are exposed, but not on linux",
+				"warns in windows/macos if no ports are exposed, but not on linux",
 				async () => {
 					const worker = helper.runLongLived("wrangler dev");
-					expect(await worker.exitCode).toBe(1);
-					expect(await worker.output).toContain(
-						'The container "http2" does not expose any ports.'
-					);
+					await worker.readUntil(/does not expose any ports/);
+					await worker.readUntil(/Container\(s\) built and ready/);
 				}
 			);
 
 			it.skipIf(process.platform !== "linux")(
-				"doesn't error in linux if no ports are exposed",
+				"doesn't warn in linux if no ports are exposed",
 				async () => {
 					const worker = helper.runLongLived("wrangler dev");
 					await worker.waitForReady();
 					await worker.readUntil(/Building container/);
 					await worker.readUntil(/DONE/);
 					await worker.readUntil(/Container\(s\) built and ready/);
+					expect(worker.output).not.toContain("does not expose any ports");
 				}
 			);
 		});

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -438,7 +438,6 @@ function resolveContainerConfig(
 			image: container.image ?? container.configuration.image,
 			maxInstances: container.max_instances,
 			imageBuildContext: container.image_build_context,
-			exposedPorts: container.dev_exposed_ports,
 			name: container.name,
 		};
 	}

packages/wrangler/src/config/environment.ts

@@ -104,11 +104,6 @@ export type ContainerApp = {
 	 *  - manual: The container application will be rollout fully by manually actioning progress steps.
 	 */
 	rollout_kind?: "full_auto" | "none" | "full_manual";
-
-	/**
-	 * Ports to be exposed by the container application. Only applies to dev, on non-linux machines, and if the Dockerfile doesn't already declare exposed ports.
-	 */
-	dev_exposed_ports?: number[];
 };
 
 /**