fix assets in directories starting with . (#8655)

* add allow dot files

* test

* changeset

* include wrangler in patch

---------

Co-authored-by: Carmen Popoviciu <[email protected]>

Author: emily-shen

.changeset/cute-plants-wash.md

@@ -0,0 +1,6 @@
+---
+"miniflare": patch
+"wrangler": patch
+---
+
+fix bug where assets in directories starting with . would crash the dev server

fixtures/workers-with-assets/public/.dot/index.html

@@ -0,0 +1 @@
+hi from .dot/index.html

fixtures/workers-with-assets/public/.dotfile.html

@@ -0,0 +1 @@
+hi from .dotfile.html

fixtures/workers-with-assets/tests/index.test.ts

@@ -247,4 +247,22 @@ describe("[Workers + Assets] dynamic site", () => {
 		// let response = await fetch(`http://${ip}:${port}/_worker.js`);
 		// expect(await response.text()).not.toContain("bang");
 	});
+
+	it("should work with files which start with .", async ({ expect }) => {
+		let response = await fetch(`http://${ip}:${port}/.dot`);
+		let text = await response.text();
+		expect(response.status).toBe(200);
+		expect(text).toMatchInlineSnapshot(`
+			"hi from .dot/index.html
+			"
+		`);
+
+		response = await fetch(`http://${ip}:${port}/.dotfile.html`);
+		text = await response.text();
+		expect(response.status).toBe(200);
+		expect(text).toMatchInlineSnapshot(`
+			"hi from .dotfile.html
+			"
+		`);
+	});
 });

packages/miniflare/src/plugins/assets/index.ts

@@ -85,7 +85,11 @@ export const ASSETS_PLUGIN: Plugin<typeof AssetsOptionsSchema> = {
 		const storageServiceName = `${ASSETS_PLUGIN_NAME}:storage`;
 		const storageService: Service = {
 			name: storageServiceName,
-			disk: { path: options.assets.directory, writable: true },
+			disk: {
+				path: options.assets.directory,
+				writable: true,
+				allowDotfiles: true,
+			},
 		};
 
 		const { encodedAssetManifest, assetsReverseMap } = await buildAssetManifest(

packages/miniflare/src/runtime/config/workerd.ts

@@ -204,6 +204,7 @@ export interface Network {
 export interface DiskDirectory {
 	path?: string;
 	writable?: boolean;
+	allowDotfiles?: boolean;
 }
 
 export interface HttpOptions {