Skip to content

Commit 785c391

Browse files
penalosaemily-shen
andauthored
Try and make unstable dev dev registry more stable (#8429)
Co-authored-by: emily-shen <[email protected]>
1 parent 8242e07 commit 785c391

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

packages/wrangler/e2e/dev-registry.test.ts

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,13 @@ describe("unstable_dev()", () => {
3434
let parent: string;
3535
let child: string;
3636
let workerName: string;
37+
let registryPath: string;
3738

3839
beforeEach(async () => {
3940
workerName = generateResourceName("worker");
4041

42+
registryPath = makeRoot();
43+
4144
parent = makeRoot();
4245

4346
await seed(parent, {
@@ -95,6 +98,7 @@ describe("unstable_dev()", () => {
9598
"index.mjs": dedent/*javascript*/ `
9699
import { unstable_dev } from "${WRANGLER_IMPORT}"
97100
import { setTimeout } from "node:timers/promises";
101+
import { readdirSync } from "node:fs"
98102
99103
const childWorker = await unstable_dev(
100104
"${child.replaceAll("\\", "/")}/src/index.ts",
@@ -105,9 +109,12 @@ describe("unstable_dev()", () => {
105109
}
106110
);
107111
108-
// Wait long enough for the child to register itself on the Worker Registry
109-
// before we boot up the parent that needs to know about it.
110-
await setTimeout(2000)
112+
for (const timeout of [1000, 2000, 4000, 8000, 16000]) {
113+
if(readdirSync(process.env.WRANGLER_REGISTRY_PATH).includes("${workerName}")) {
114+
break
115+
}
116+
await setTimeout(timeout)
117+
}
111118
112119
const parentWorker = await unstable_dev(
113120
"src/index.ts",
@@ -126,6 +133,10 @@ describe("unstable_dev()", () => {
126133
const stdout = execSync(`node index.mjs`, {
127134
cwd: parent,
128135
encoding: "utf-8",
136+
env: {
137+
...process.env,
138+
WRANGLER_REGISTRY_PATH: registryPath,
139+
},
129140
});
130141
return stdout;
131142
}

0 commit comments

Comments
 (0)