Skip to content

Commit 7923273

Browse files
committed
Skip prerendering test on Vite 6 because buildApp hook is not supported
1 parent a6ae450 commit 7923273

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

packages/vite-plugin-cloudflare/playground/__test-utils__/index.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
import fs from "node:fs";
2-
import { version } from "vite";
2+
import semverGte from "semver/functions/gte";
3+
import { version as viteVersion } from "vite";
34
import { onTestFinished, test } from "vitest";
45
import { isWindows } from "../vitest-setup";
56

67
export * from "../vitest-setup";
78
export * from "./responses";
89

10+
export function satisfiesViteVersion(minVersion: string): boolean {
11+
return semverGte(viteVersion, minVersion);
12+
}
13+
914
// TODO: remove when all tests are passing with Vite 8
10-
export const isVite8 = version.split(".")[0] === "8";
15+
export const isVite8 = viteVersion.split(".")[0] === "8";
1116

1217
/** Common options to use with `vi.waitFor()` */
1318
export const WAIT_FOR_OPTIONS = {

packages/vite-plugin-cloudflare/playground/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"@cloudflare/vite-plugin": "workspace:*",
1818
"@cloudflare/workers-tsconfig": "workspace:*",
1919
"playwright-chromium": "catalog:default",
20+
"semver": "^7.7.1",
2021
"strip-ansi": "^7.1.0",
2122
"ts-dedent": "^2.2.0",
2223
"typescript": "catalog:default"

packages/vite-plugin-cloudflare/playground/prerendering/__tests__/prerendering.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@ import {
33
getTextResponse,
44
isBuild,
55
page,
6+
satisfiesViteVersion,
67
viteTestUrl,
78
} from "../../__test-utils__";
89

910
test("returns the server rendered route at /", async () => {
1011
expect(await getTextResponse()).toEqual("Hello world");
1112
});
1213

13-
test.runIf(isBuild)(
14+
test.runIf(isBuild && satisfiesViteVersion("7.0.0"))(
1415
"returns the prerendered route at /prerendered after the build",
1516
async () => {
1617
await page.goto(`${viteTestUrl}/prerendered`);

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)