Skip to content

Commit 7b9a624

Browse files
remove startDev change
1 parent b9b0e54 commit 7b9a624

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

packages/wrangler/src/dev.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ export const dev = createCommand({
286286
}
287287
},
288288
async handler(args) {
289-
const devInstance = await startDev({ ...args, forceLocal: args.local });
289+
const devInstance = await startDev({ ...args });
290290
assert(devInstance.devEnv !== undefined);
291291
await events.once(devInstance.devEnv, "teardown");
292292
await Promise.all(devInstance.secondary.map((d) => d.teardown()));

packages/wrangler/src/dev/start-dev.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -251,12 +251,9 @@ async function setupDevEnv(
251251
args.remote || (args.forceLocal || args.local ? false : undefined),
252252
remoteBindings:
253253
// Note: this ternary is a hack, just to make sure that `wrangler pages dev`
254-
// supports the AI binding (the issue is that `wrangler pages dev` sets
255-
// `forceLocal` to true, so it should disable all remote bindings, but it
256-
// still needs to support the AI bindings regardless because removing such
257-
// support now would be a breaking change)
258-
// TODO: remove this hack in wrangler v5 (the following line should just be `!!args.forceLocal,`)
259-
args.enablePagesAssetsServiceBinding ? true : !args.forceLocal,
254+
// supports the AI binding (removing such support now would be a breaking change)
255+
// TODO: remove this hack in wrangler v5 (the following line should just be `args.local !== true,`)
256+
args.enablePagesAssetsServiceBinding ? true : args.local !== true,
260257
server: {
261258
hostname: args.ip,
262259
port: args.port,

0 commit comments

Comments
 (0)