CFSQL-1261: remove the need for d1 to patch wrangler for testing (#9748)

* CFSQL-1261: Let D1 team stop patching wrangler for testing

* CFSQL-1261: add changeset

Author: alsuren

.changeset/wild-books-search.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Internal-only WRANGLER_D1_EXTRA_LOCATION_CHOICES environment variable for enabling D1's testing location hints

packages/wrangler/src/d1/create.ts

@@ -2,6 +2,7 @@ import dedent from "ts-dedent";
 import { fetchResult } from "../cfetch";
 import { formatConfigSnippet } from "../config";
 import { createCommand } from "../core/create-command";
+import { getD1ExtraLocationChoices } from "../environment-variables/misc-variables";
 import { UserError } from "../errors";
 import { logger } from "../logger";
 import { requireAuth } from "../user";
@@ -53,7 +54,10 @@ export const d1CreateCommand = createCommand({
 		},
 		location: {
 			type: "string",
-			choices: LOCATION_CHOICES,
+			choices: [
+				...LOCATION_CHOICES,
+				...(getD1ExtraLocationChoices()?.split(",") ?? []),
+			],
 			description: dedent`
 					A hint for the primary location of the new DB. Options:
 						weur: Western Europe

packages/wrangler/src/environment-variables/factory.ts

@@ -33,6 +33,7 @@ type VariableNames =
 	| "WRANGLER_BUILD_CONDITIONS"
 	| "WRANGLER_BUILD_PLATFORM"
 	| "WRANGLER_REGISTRY_PATH"
+	| "WRANGLER_D1_EXTRA_LOCATION_CHOICES"
 	| "WRANGLER_DOCKER_BIN"
 	| "WRANGLER_DOCKER_HOST";
 

packages/wrangler/src/environment-variables/misc-variables.ts

@@ -248,6 +248,16 @@ export const getRegistryPath = getEnvironmentVariableFactory({
 	},
 });
 
+/**
+ * `WRANGLER_D1_EXTRA_LOCATION_CHOICES` is an internal variable to let D1 team target their testing environments.
+ *
+ * External accounts cannot access testing envionments, so should not set this variable.
+ */
+export const getD1ExtraLocationChoices: () => string | undefined =
+	getEnvironmentVariableFactory({
+		variableName: "WRANGLER_D1_EXTRA_LOCATION_CHOICES",
+	});
+
 /**
  * `WRANGLER_DOCKER_BIN` specifies the path to a docker binary.
  *

packages/wrangler/turbo.json

@@ -45,6 +45,7 @@
 				"WORKERS_CI",
 				"WRANGLER_API_ENVIRONMENT",
 				"WRANGLER_AUTH_DOMAIN",
+				"WRANGLER_D1_EXTRA_LOCATION_CHOICES",
 				"WRANGLER_DISABLE_EXPERIMENTAL_WARNING",
 				"WRANGLER_DISABLE_REQUEST_BODY_DRAINING",
 				"WRANGLER_LOG",