make workers created with startWorker await the ready promise on dispose (#9541)

* make workers created with `startWorker` await the `ready` promise on `dispose`

* Revert "make workers created with `startWorker` await the `ready` promise on `dispose`"

This reverts commit 8e7fa7a.

* reject ready promise instead of resolving it to null

* fix typo in test assert match

* properly fix typo

* Update packages/wrangler/src/api/startDevWorker/DevEnv.ts

Co-authored-by: Pete Bacon Darwin <[email protected]>

* update tests

* fix formatting

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>

Author: dario-piotrowicz

.changeset/five-shoes-call.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+make workers created with `startWorker` await the `ready` promise on `dispose`

fixtures/start-worker-node-test/src/config-errors.test.js

@@ -12,9 +12,15 @@ describe("startWorker - configuration errors", () => {
 			}),
 			(err) => {
 				assert(err instanceof Error);
-				assert.match(
+				assert.strictEqual(
 					err.message,
-					/he entry-point file at "not a real entrypoint" was not found./
+					"An error occurred when starting the server"
+				);
+				const cause = err.cause;
+				assert(cause instanceof Error);
+				assert.match(
+					cause.message,
+					/The entry-point file at "not a real entrypoint" was not found./
 				);
 				return true;
 			}
@@ -26,8 +32,14 @@ describe("startWorker - configuration errors", () => {
 			unstable_startWorker({ config: "non-existing-config" }),
 			(err) => {
 				assert(err instanceof Error);
-				assert.match(
+				assert.strictEqual(
 					err.message,
+					"An error occurred when starting the server"
+				);
+				const cause = err.cause;
+				assert(cause instanceof Error);
+				assert.match(
+					cause.message,
 					/Missing entry-point to Worker script or to assets directory/
 				);
 				return true;
@@ -58,8 +70,6 @@ describe("startWorker - configuration errors", () => {
 			}
 		);
 
-		// TODO: worker.dispose() should itself await worker.ready
-		await worker.ready;
 		await worker.dispose();
 	});
 
@@ -86,8 +96,6 @@ describe("startWorker - configuration errors", () => {
 			}
 		);
 
-		// TODO: worker.dispose() should itself await worker.ready
-		await worker.ready;
 		await worker.dispose();
 	});
 });

packages/wrangler/src/api/startDevWorker/DevEnv.ts

@@ -23,6 +23,10 @@ export class DevEnv extends EventEmitter {
 		try {
 			await this.config.set(options, true);
 		} catch (e) {
+			const error = new Error("An error occurred when starting the server", {
+				cause: e,
+			});
+			this.proxy.ready.reject(error);
 			await worker.dispose();
 			throw e;
 		}
@@ -186,7 +190,7 @@ function createWorkerObject(devEnv: DevEnv): Worker {
 			return w.scheduled(...args);
 		},
 		async dispose() {
-			await devEnv.teardown();
+			await devEnv.proxy.ready.promise.finally(() => devEnv.teardown());
 		},
 		raw: devEnv,
 	};