remove color characters from test inline snapshots

Author: dario-piotrowicz

packages/wrangler/src/__tests__/deploy.test.ts

@@ -14711,6 +14711,37 @@ export default{
 		});
 	});
 
+	function normalizeLogWithConfigDiff(log: string): string {
+		// If the path is long the log could be wrapped so we need to remove the potential wrapping
+		let normalizedLog = log.replace(/"main":\s*"/, '"main": "');
+
+		if (process.platform === "win32") {
+			// On windows the snapshot paths incorrectly use double slashes, such as:
+			//  `\"main\": \"C://Users//RUNNER~1//AppData//Local//Temp//wrangler-testse63LuJ//index.js\",
+			// so in the `main` field we replace all possible occurrences of `//` with just `\\`
+			// (so that the path normalization of `normalizeString` can appropriately work)
+			normalizedLog = normalizedLog.replace(
+				/"main": "(.*?)"/,
+				(_, mainPath: string) => `"main": "${mainPath.replaceAll("//", "\\")}"`
+			);
+		}
+
+		normalizedLog = normalizeString(normalizedLog);
+
+		// normalizedLog = normalizedLog.replaceAll("\t", "<__TAB__>");
+		// normalizedLog = normalizedLog.replaceAll(" ", "<__SPACE__>");
+
+		// Let's remove the various extra characters for colors to get a more clear
+		normalizedLog = normalizedLog
+			.replaceAll("", "X")
+			.replaceAll(/X\[\d+(?:;\d+)?m/g, "");
+
+		// Let's also normalize Windows newlines
+		normalizedLog = normalizedLog.replaceAll("\r\n", "\n");
+
+		return normalizedLog;
+	}
+
 	describe("config remote differences", () => {
 		it("should present a diff warning to the user when there are differences between the local config (json/jsonc) and the dash config", async () => {
 			writeWorkerSource();
@@ -14760,12 +14791,12 @@ export default{
 			await runWrangler("deploy --x-remote-diff-check");
 
 			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
-				"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:[0m
+				"▲ [WARNING] The local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:
 
 				   {
 				     vars: {
-				  [31m-    MY_VAR: \\"abc\\"[39m
-				  [32m+    MY_VAR: 123[39m
+				  -    MY_VAR: \\"abc\\"
+				  +    MY_VAR: 123
 				     }
 				   }
 
@@ -14827,12 +14858,12 @@ export default{
 			//       to be able to show toml content/diffs, that combined with the fact that json(c) config files are the
 			//       recommended ones moving forward makes this small shortcoming of the config diffing acceptable
 			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
-				"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:[0m
+				"▲ [WARNING] The local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:
 
 				   {
 				     vars: {
-				  [31m-    MY_VAR: \\"abc\\"[39m
-				  [32m+    MY_VAR: \\"this is a toml file\\"[39m
+				  -    MY_VAR: \\"abc\\"
+				  +    MY_VAR: \\"this is a toml file\\"
 				     }
 				   }
 
@@ -14842,27 +14873,6 @@ export default{
 				"
 			`);
 		});
-
-		function normalizeLogWithConfigDiff(log: string): string {
-			// If the path is long the log could be wrapped so we need to remove the potential wrapping
-			let normalizedLog = log.replace(/"main":\s*"/, '"main": "');
-
-			if (process.platform === "win32") {
-				// On windows the snapshot paths incorrectly use double slashes, such as:
-				//  `\"main\": \"C://Users//RUNNER~1//AppData//Local//Temp//wrangler-testse63LuJ//index.js\",
-				// so in the `main` field we replace all possible occurrences of `//` with just `\\`
-				// (so that the path normalization of `normalizeString` can appropriately work)
-				normalizedLog = normalizedLog.replace(
-					/"main": "(.*?)"/,
-					(_, mainPath: string) =>
-						`"main": "${mainPath.replaceAll("//", "\\")}"`
-				);
-			}
-
-			normalizedLog = normalizeString(normalizedLog);
-
-			return normalizedLog;
-		}
 	});
 
 	describe("with strict mode enabled", () => {
@@ -14902,13 +14912,13 @@ export default{
 
 			await runWrangler("deploy --x-remote-diff-check --strict");
 
-			expect(std.warn).toMatchInlineSnapshot(`
-				"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mThe local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:[0m
+			expect(normalizeLogWithConfigDiff(std.warn)).toMatchInlineSnapshot(`
+				"▲ [WARNING] The local configuration being used (generated from your local configuration file) differs from the remote configuration of your Worker set via the Cloudflare Dashboard:
 
 				   {
 				     observability: {
-				  [31m-    enabled: true[39m
-				  [32m+    enabled: false[39m
+				  -    enabled: true
+				  +    enabled: false
 				     }
 				   }
 

packages/wrangler/src/__tests__/deploy/config-diffs.test.ts

@@ -1,6 +1,20 @@
 import { getRemoteConfigDiff } from "../../deploy/config-diffs";
 import type { Config, RawConfig } from "../../config";
 
+function normalizeDiff(log: string): string {
+	let normalizedLog = log;
+
+	// Let's remove the various extra characters for colors to get a more clear
+	normalizedLog = normalizedLog
+		.replaceAll("", "X")
+		.replaceAll(/X\[\d+(?:;\d+)?m/g, "");
+
+	// Let's also normalize Windows newlines
+	normalizedLog = normalizedLog.replaceAll("\r\n", "\n");
+
+	return normalizedLog;
+}
+
 describe("getRemoteConfigsDiff", () => {
 	it("should handle a very simple diffing scenario (no diffs, random order)", () => {
 		const { diff, nonDestructive } = getRemoteConfigDiff(
@@ -61,10 +75,10 @@ describe("getRemoteConfigsDiff", () => {
 		);
 
 		assert(diff);
-		expect(diff.toString()).toMatchInlineSnapshot(`
+		expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 			" {
-			[31m-  compatibility_date: \\"2025-07-08\\"[39m
-			[32m+  compatibility_date: \\"2025-07-09\\"[39m
+			-  compatibility_date: \\"2025-07-08\\"
+			+  compatibility_date: \\"2025-07-09\\"
 			 }
 			"
 		`);
@@ -98,14 +112,14 @@ describe("getRemoteConfigsDiff", () => {
 			} as unknown as Config
 		);
 		assert(diff);
-		expect(diff.toString()).toMatchInlineSnapshot(`
+		expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 			" {
 			   kv_namespaces: [
 			     ...
-			[32m+    {[39m
-			[32m+      binding: \\"MY_KV_2\\"[39m
-			[32m+      id: \\"my-kv-456\\"[39m
-			[32m+    }[39m
+			+    {
+			+      binding: \\"MY_KV_2\\"
+			+      id: \\"my-kv-456\\"
+			+    }
 			   ]
 			 }
 			"
@@ -142,14 +156,14 @@ describe("getRemoteConfigsDiff", () => {
 			} as unknown as Config
 		);
 		assert(diff);
-		expect(diff.toString()).toMatchInlineSnapshot(`
+		expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 			" {
-			[31m-  kv_namespaces: [[39m
-			[31m-    {[39m
-			[31m-      binding: \\"MY_KV\\"[39m
-			[31m-      id: \\"my-kv-123\\"[39m
-			[31m-    }[39m
-			[31m-  ][39m
+			-  kv_namespaces: [
+			-    {
+			-      binding: \\"MY_KV\\"
+			-      id: \\"my-kv-123\\"
+			-    }
+			-  ]
 			 }
 			"
 		`);
@@ -182,19 +196,19 @@ describe("getRemoteConfigsDiff", () => {
 			} as unknown as Config
 		);
 		assert(diff);
-		expect(diff.toString()).toMatchInlineSnapshot(`
+		expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 			" {
-			[31m-  kv_namespaces: [[39m
-			[31m-    {[39m
-			[31m-      binding: \\"MY_KV\\"[39m
-			[31m-      id: \\"my-kv-123\\"[39m
-			[31m-    }[39m
-			[31m-  ][39m
-			[31m-  compatibility_date: \\"2025-07-08\\"[39m
-			[32m+  compatibility_date: \\"2025-07-09\\"[39m
+			-  kv_namespaces: [
+			-    {
+			-      binding: \\"MY_KV\\"
+			-      id: \\"my-kv-123\\"
+			-    }
+			-  ]
+			-  compatibility_date: \\"2025-07-08\\"
+			+  compatibility_date: \\"2025-07-09\\"
 			   observability: {
-			[31m-    enabled: true[39m
-			[32m+    enabled: false[39m
+			-    enabled: true
+			+    enabled: false
 			   }
 			 }
 			"
@@ -249,11 +263,11 @@ describe("getRemoteConfigsDiff", () => {
 				{ enabled: true }
 			);
 			assert(diff);
-			expect(diff.toString()).toMatchInlineSnapshot(`
+			expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 				" {
 				   observability: {
-				[31m-    enabled: false[39m
-				[32m+    enabled: true[39m
+				-    enabled: false
+				+    enabled: true
 				   }
 				 }
 				"
@@ -267,12 +281,12 @@ describe("getRemoteConfigsDiff", () => {
 				{ logs: { enabled: true } }
 			);
 			assert(diff);
-			expect(diff.toString()).toMatchInlineSnapshot(`
+			expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 				" {
 				   observability: {
 				     logs: {
-				[31m-      enabled: false[39m
-				[32m+      enabled: true[39m
+				-      enabled: false
+				+      enabled: true
 				     }
 				   }
 				 }
@@ -298,12 +312,12 @@ describe("getRemoteConfigsDiff", () => {
 				{ logs: { enabled: true, head_sampling_rate: 0.9 } }
 			);
 			assert(diff);
-			expect(diff.toString()).toMatchInlineSnapshot(`
+			expect(normalizeDiff(diff.toString())).toMatchInlineSnapshot(`
 				" {
 				   observability: {
 				     logs: {
-				[31m-      head_sampling_rate: 1[39m
-				[32m+      head_sampling_rate: 0.9[39m
+				-      head_sampling_rate: 1
+				+      head_sampling_rate: 0.9
 				     }
 				   }
 				 }