V3 Backport for #8924 (#8928)

* fix redirected config env validation breaking wrangler pages commands

* add tests for pages deploy command

* remove extra unnecessary check

Author: dario-piotrowicz

.changeset/odd-steaks-cheat.md

@@ -0,0 +1,12 @@
+---
+"wrangler": patch
+---
+
+fix redirected config env validation breaking wrangler pages commands
+
+a validation check has recently been introduced to make wrangler error on
+deploy commands when an environment is specified and a redirected configuration
+is in use (the reason being that redirected configurations should not include
+any environment), this check is problematic with pages commands where the
+"production" environment is anyways set by default, to address this the validation
+check is being relaxed here on pages commands

packages/wrangler/src/__tests__/pages/deploy.test.ts

@@ -5649,6 +5649,84 @@ Failed to publish your Function. Got error: Uncaught TypeError: a is not a funct
 			expect(std.err).toMatchInlineSnapshot(`""`);
 		});
 	});
+
+	describe("deploys using redirected configs", () => {
+		let fooProjectDetailsChecked = false;
+
+		beforeEach(() => {
+			fooProjectDetailsChecked = false;
+			mkdirSync("public");
+			mkdirSync("dist");
+			mkdirSync(".wrangler/deploy", { recursive: true });
+			writeFileSync(
+				".wrangler/deploy/config.json",
+				JSON.stringify({ configPath: "../../dist/wrangler.json" })
+			);
+			writeFileSync(
+				"dist/wrangler.json",
+				JSON.stringify({
+					compatibility_date: "2025-01-01",
+					name: "foo",
+					pages_build_output_dir: "../public",
+				})
+			);
+
+			simulateServer(async () => {});
+
+			msw.use(
+				http.get(
+					"*/accounts/:accountId/pages/projects/foo",
+					async ({ params }) => {
+						expect(params.accountId).toEqual("some-account-id");
+
+						fooProjectDetailsChecked = true;
+
+						return HttpResponse.json(
+							{
+								success: true,
+								errors: [],
+								messages: [],
+								result: {
+									production_branch: "main",
+									deployment_configs: {
+										production: {},
+										preview: {},
+									},
+								} as Partial<Project>,
+							},
+							{ status: 200 }
+						);
+					}
+				)
+			);
+		});
+
+		afterEach(() => {
+			expect(fooProjectDetailsChecked).toBe(true);
+		});
+
+		const expectedInfo = dedent`
+			Using redirected Wrangler configuration.
+			 - Configuration being used: "dist/wrangler.json"
+			 - Original user's configuration: "<no user config found>"
+			 - Deploy configuration file: ".wrangler/deploy/config.json"
+		`;
+
+		it("should work without a branch specified (i.e. defaulting to the production environment)", async () => {
+			await runWrangler("pages deploy");
+			expect(std.info).toContain(expectedInfo);
+		});
+
+		it("should work with the main branch (i.e. the production environment)", async () => {
+			await runWrangler("pages deploy --branch main");
+			expect(std.info).toContain(expectedInfo);
+		});
+
+		it("should work with any branch (i.e. the preview environment)", async () => {
+			await runWrangler("pages deploy --branch my-branch");
+			expect(std.info).toContain(expectedInfo);
+		});
+	});
 });
 
 function mockGetProjectHandler(

packages/wrangler/src/config/validation.ts

@@ -212,11 +212,15 @@ export function normalizeAndValidateConfig(
 
 	if (envName !== undefined) {
 		if (isRedirectedConfig) {
-			diagnostics.errors.push(dedent`
-				You have specified the environment "${envName}", but are using a redirected configuration, produced by a build tool such as Vite.
-				You need to set the environment in your build tool, rather than via Wrangler.
-				For example, if you are using Vite, refer to these docs: https://developers.cloudflare.com/workers/vite-plugin/reference/cloudflare-environments/
-			`);
+			// Note: we error if the user is specifying an environment, but not for pages
+			//       commands where the environment is always set (to either "preview" or "production")
+			if (!isPagesConfig(rawConfig)) {
+				diagnostics.errors.push(dedent`
+					You have specified the environment "${envName}", but are using a redirected configuration, produced by a build tool such as Vite.
+					You need to set the environment in your build tool, rather than via Wrangler.
+					For example, if you are using Vite, refer to these docs: https://developers.cloudflare.com/workers/vite-plugin/reference/cloudflare-environments/
+				`);
+			}
 		} else {
 			const envDiagnostics = new Diagnostics(
 				`"env.${envName}" environment configuration`