Update r2 domain tests to check for confirmation prompts

Author: jonesphillip

.changeset/tame-dryers-end.md

@@ -1,5 +1,5 @@
 ---
-"wrangler": patch
+"wrangler": minor
 ---
 
 Added the ability to list, add, remove, and update R2 bucket custom domains.

packages/wrangler/src/__tests__/r2.test.ts

@@ -5,6 +5,7 @@ import { actionsForEventCategories } from "../r2/helpers";
 import { endEventLoop } from "./helpers/end-event-loop";
 import { mockAccountId, mockApiToken } from "./helpers/mock-account-id";
 import { mockConsoleMethods } from "./helpers/mock-console";
+import { mockConfirm } from "./helpers/mock-dialogs";
 import { useMockIsTTY } from "./helpers/mock-istty";
 import { createFetchResult, msw, mswR2handlers } from "./helpers/msw";
 import { runInTempDir } from "./helpers/run-in-tmp";
@@ -1470,13 +1471,22 @@ describe("r2", () => {
 			});
 		});
 		describe("domain", () => {
+			const { setIsTTY } = useMockIsTTY();
 			mockAccountId();
 			mockApiToken();
 			describe("add", () => {
 				it("should add custom domain to the bucket as expected", async () => {
 					const bucketName = "my-bucket";
 					const domainName = "example.com";
 					const zoneId = "zone-id-123";
+
+					setIsTTY(true);
+					mockConfirm({
+						text:
+							`Are you sure you want to add the custom domain '${domainName}' to bucket '${bucketName}'? ` +
+							`The contents of your bucket will be made publicly available at 'https://${domainName}'`,
+						result: true,
+					});
 					msw.use(
 						http.post(
 							"*/accounts/:accountId/r2/buckets/:bucketName/domains/custom",
@@ -1497,7 +1507,7 @@ describe("r2", () => {
 						)
 					);
 					await runWrangler(
-						`r2 bucket domain add ${bucketName} --domain ${domainName} --zone-id ${zoneId} --force`
+						`r2 bucket domain add ${bucketName} --domain ${domainName} --zone-id ${zoneId}`
 					);
 					expect(std.out).toMatchInlineSnapshot(`
 				"Connecting custom domain 'example.com' to bucket 'my-bucket'...
@@ -1508,7 +1518,7 @@ describe("r2", () => {
 				it("should error if domain and zone-id are not provided", async () => {
 					const bucketName = "my-bucket";
 					await expect(
-						runWrangler(`r2 bucket domain add ${bucketName} --force`)
+						runWrangler(`r2 bucket domain add ${bucketName}`)
 					).rejects.toThrowErrorMatchingInlineSnapshot(
 						`[Error: Missing required arguments: domain, zone-id]`
 					);
@@ -1587,6 +1597,13 @@ describe("r2", () => {
 				it("should remove a custom domain as expected", async () => {
 					const bucketName = "my-bucket";
 					const domainName = "example.com";
+					setIsTTY(true);
+					mockConfirm({
+						text:
+							`Are you sure you want to remove the custom domain '${domainName}' from bucket '${bucketName}'? ` +
+							`Your bucket will no longer be available from 'https://${domainName}'`,
+						result: true,
+					});
 					msw.use(
 						http.delete(
 							"*/accounts/:accountId/r2/buckets/:bucketName/domains/custom/:domainName",
@@ -1605,7 +1622,7 @@ describe("r2", () => {
 						)
 					);
 					await runWrangler(
-						`r2 bucket domain remove ${bucketName} --domain ${domainName} --force`
+						`r2 bucket domain remove ${bucketName} --domain ${domainName}`
 					);
 					expect(std.out).toMatchInlineSnapshot(`
 				"Removing custom domain 'example.com' from bucket 'my-bucket'...