improve(wrangler): bounds checking for when setting queue delivery delay

Author: TaraGarg

.changeset/sharp-numbers-search.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Check bounds when overriding delivery delay when creating Queues

packages/wrangler/src/__tests__/queues.test.ts

@@ -328,6 +328,17 @@ describe("wrangler", () => {
 
 				expect(requests.count).toEqual(0);
 			});
+
+			it("should show an error when invalid delivery delay is set", async () => {
+				const requests = mockCreateRequest("testQueue", { delivery_delay: 10 });
+				await expect(
+					runWrangler("queues create testQueue --delivery-delay-secs=99999")
+				).rejects.toThrowErrorMatchingInlineSnapshot(
+					`[Error: Invalid --delivery-delay-secs value: 99999. Must be between 0 and 42300]`
+				);
+
+				expect(requests.count).toEqual(0);
+			});
 		});
 
 		describe("delete", () => {
@@ -714,12 +725,12 @@ describe("wrangler", () => {
 				"Adding consumer to queue testQueue.
 				Queues is not currently enabled on this account. Go to https://dash.cloudflare.com/some-account-id/workers/queues to enable it.
 
-				[31mX [41;31m[[41;97mERROR[41;31m][0m [1mA request to the Cloudflare API (/accounts/some-account-id/queues/testQueue/consumers) failed.[0m
+				�[31mX �[41;31m[�[41;97mERROR�[41;31m]�[0m �[1mA request to the Cloudflare API (/accounts/some-account-id/queues/testQueue/consumers) failed.�[0m
 
 				  workers.api.error.unauthorized [code: 10023]
 
 				  If you think this is a bug, please open an issue at:
-				  [4mhttps://github.com/cloudflare/workers-sdk/issues/new/choose[0m
+				  �[4mhttps://github.com/cloudflare/workers-sdk/issues/new/choose�[0m
 
 				"
 			`);

packages/wrangler/src/queues/cli/commands/create.ts

@@ -4,6 +4,10 @@ import { CommandLineArgsError } from "../../../errors";
 import { logger } from "../../../logger";
 import { getValidBindingName } from "../../../utils/getValidBindingName";
 import { createQueue } from "../../client";
+import {
+	MAX_DELIVERY_DELAY_SECS,
+	MIN_DELIVERY_DELAY_SECS,
+} from "../../constants";
 import { handleFetchError } from "../../utils";
 import type {
 	CommonYargsArgv,
@@ -22,7 +26,8 @@ export function options(yargs: CommonYargsArgv) {
 			"delivery-delay-secs": {
 				type: "number",
 				describe:
-					"How long a published message should be delayed for, in seconds. Must be a positive integer",
+					"How long a published message should be delayed for, in seconds. Must be between 0 and 42300",
+				default: 0,
 			},
 		});
 }
@@ -40,10 +45,22 @@ function createBody(
 		);
 	}
 
+	body.settings = {};
+
 	if (args.deliveryDelaySecs != undefined) {
-		body.settings = {
-			delivery_delay: args.deliveryDelaySecs,
-		};
+		if (
+			args.deliveryDelaySecs < MIN_DELIVERY_DELAY_SECS ||
+			args.deliveryDelaySecs > MAX_DELIVERY_DELAY_SECS
+		) {
+			throw new CommandLineArgsError(
+				`Invalid --delivery-delay-secs value: ${args.deliveryDelaySecs}. Must be between ${MIN_DELIVERY_DELAY_SECS} and ${MAX_DELIVERY_DELAY_SECS}`
+			);
+		}
+		body.settings.delivery_delay = args.deliveryDelaySecs;
+	}
+
+	if (Object.keys(body.settings).length === 0) {
+		body.settings = undefined;
 	}
 
 	return body;

packages/wrangler/src/queues/constants.ts

@@ -1,2 +1,5 @@
 export const INVALID_CONSUMER_SETTINGS_ERROR = 100127;
 export const INVALID_QUEUE_SETTINGS_ERROR = 100128;
+
+export const MIN_DELIVERY_DELAY_SECS = 0;
+export const MAX_DELIVERY_DELAY_SECS = 43200;