Skip to content

Commit 93b177f

Browse files
authored
[c3] Bump create-vite to 8.3.0 and update React test expected text (#12531)
1 parent b7cf337 commit 93b177f

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"create-cloudflare": patch
3+
---
4+
5+
Update dependencies of "create-cloudflare"
6+
7+
The following dependency versions have been updated:
8+
9+
| Dependency | From | To |
10+
| ----------- | ----- | ----- |
11+
| create-vite | 7.1.1 | 8.3.0 |

packages/create-cloudflare/e2e/tests/frameworks/test-config.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -410,12 +410,17 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
410410
timeout: LONG_TIMEOUT,
411411
verifyDeploy: {
412412
route: "/",
413-
expectedText: "Vite + React",
413+
// Note that this is the text in the static HTML that is returned
414+
// This React SPA will change this at runtime but we are only making a fetch request
415+
// not actually running the client side JS.
416+
// create-vite 8+ changed the <title> from "Vite + React + TS" to the project name,
417+
// so we match on the React root element instead.
418+
expectedText: '<div id="root">',
414419
},
415420
verifyPreview: {
416421
previewArgs: ["--inspector-port=0"],
417422
route: "/",
418-
expectedText: "Vite + React",
423+
expectedText: '<div id="root">',
419424
},
420425
nodeCompat: false,
421426
},
@@ -435,7 +440,9 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
435440
// Note that this is the text in the static HTML that is returned
436441
// This React SPA will change this at runtime but we are only making a fetch request
437442
// not actually running the client side JS.
438-
expectedText: "Vite + React + TS",
443+
// create-vite 8+ changed the <title> from "Vite + React + TS" to the project name,
444+
// so we match on the React root element instead.
445+
expectedText: '<div id="root">',
439446
},
440447
verifyPreview: {
441448
route: "/",
@@ -445,7 +452,7 @@ function getFrameworkTestConfig(pm: string): NamedFrameworkTestConfig[] {
445452
// Note that this is the text in the static HTML that is returned
446453
// This React SPA will change this at runtime but we are only making a fetch request
447454
// not actually running the client side JS.
448-
expectedText: "Vite + React + TS",
455+
expectedText: '<div id="root">',
449456
},
450457
nodeCompat: false,
451458
},
@@ -892,7 +899,9 @@ function getExperimentalFrameworkTestConfig(
892899
// Note that this is the text in the static HTML that is returned
893900
// This React SPA will change this at runtime but we are only making a fetch request
894901
// not actually running the client side JS.
895-
expectedText: "Vite + React + TS",
902+
// create-vite 8+ changed the <title> from "Vite + React + TS" to the project name,
903+
// so we match on the React root element instead.
904+
expectedText: '<div id="root">',
896905
},
897906
verifyPreview: {
898907
route: "/",
@@ -902,7 +911,7 @@ function getExperimentalFrameworkTestConfig(
902911
// Note that this is the text in the static HTML that is returned
903912
// This React SPA will change this at runtime but we are only making a fetch request
904913
// not actually running the client side JS.
905-
expectedText: "Vite + React + TS",
914+
expectedText: '<div id="root">',
906915
},
907916
nodeCompat: false,
908917
verifyTypes: false,

packages/create-cloudflare/src/frameworks/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"create-hono": "0.19.4",
1313
"create-next-app": "15.5.6",
1414
"create-qwik": "1.19.0",
15-
"create-vite": "7.1.1",
15+
"create-vite": "8.3.0",
1616
"create-rwsdk": "3.1.3",
1717
"create-react-router": "7.13.0",
1818
"create-solid": "0.6.11",

0 commit comments

Comments
 (0)