fix: add warning when subdomain status does not match Wrangler config

Warn the user when the workers.dev or preview URLs status does not match
their Wrangler config file.

Author: danielrs

packages/wrangler/src/__tests__/deploy.test.ts

@@ -6891,6 +6891,60 @@ addEventListener('fetch', event => {});`
 			expect(std.err).toMatchInlineSnapshot(`""`);
 			expect(std.warn).toMatchInlineSnapshot(`""`);
 		});
+
+		it("should warn the user if workers_dev default is different from remote", async () => {
+			writeWranglerConfig({}); // Default workers_dev should be true, since there's no routes.
+			writeWorkerSource();
+			mockSubDomainRequest();
+			mockUploadWorkerRequest();
+			mockGetWorkerSubdomain({ enabled: false });
+			mockUpdateWorkerSubdomain({ enabled: true });
+			await runWrangler("deploy ./index");
+
+			expect(std.out).toMatchInlineSnapshot(`
+				"Total Upload: xx KiB / gzip: xx KiB
+				Worker Startup Time: 100 ms
+				Uploaded test-name (TIMINGS)
+				Deployed test-name triggers (TIMINGS)
+				  https://test-name.test-sub-domain.workers.dev
+				Current Version ID: Galaxy-Class"
+			`);
+			expect(std.err).toMatchInlineSnapshot(`""`);
+			expect(std.warn).toMatchInlineSnapshot(`
+				"▲ [WARNING] Worker has workers.dev disabled, but 'workers_dev' is not in the config.
+
+				  Using fallback value 'workers_dev = true'.
+
+				"
+			`);
+		});
+
+		it("should warn the user if preview_urls default is different from remote", async () => {
+			writeWranglerConfig({}); // Default preview_urls should be false.
+			writeWorkerSource();
+			mockSubDomainRequest();
+			mockUploadWorkerRequest();
+			mockGetWorkerSubdomain({ enabled: true, previews_enabled: true });
+			mockUpdateWorkerSubdomain({ enabled: true, previews_enabled: false });
+			await runWrangler("deploy ./index");
+
+			expect(std.out).toMatchInlineSnapshot(`
+				"Total Upload: xx KiB / gzip: xx KiB
+				Worker Startup Time: 100 ms
+				Uploaded test-name (TIMINGS)
+				Deployed test-name triggers (TIMINGS)
+				  https://test-name.test-sub-domain.workers.dev
+				Current Version ID: Galaxy-Class"
+			`);
+			expect(std.err).toMatchInlineSnapshot(`""`);
+			expect(std.warn).toMatchInlineSnapshot(`
+				"▲ [WARNING] Worker has preview URLs enabled, but 'preview_urls' is not in the config.
+
+				  Using fallback value 'preview_urls = false'.
+
+				"
+			`);
+		});
 	});
 
 	describe("[define]", () => {

packages/wrangler/src/triggers/deploy.ts

@@ -336,6 +336,28 @@ async function subdomainDeploy(
 	const previewsInSync = wantPreviews === currPreviews;
 	const allInSync = [workersDevInSync, previewsInSync].every((v) => v);
 
+	// Warn about mismatching config and current values.
+
+	if (config.workers_dev == undefined && !workersDevInSync) {
+		const currWorkersDevStatus = currWorkersDev ? "enabled" : "disabled";
+		logger.warn(
+			[
+				`Worker has workers.dev ${currWorkersDevStatus}, but 'workers_dev' is not in the config.`,
+				`Using fallback value 'workers_dev = ${wantWorkersDev}'.`,
+			].join("\n")
+		);
+	}
+
+	if (config.preview_urls == undefined && !previewsInSync) {
+		const currPreviewsStatus = currPreviews ? "enabled" : "disabled";
+		logger.warn(
+			[
+				`Worker has preview URLs ${currPreviewsStatus}, but 'preview_urls' is not in the config.`,
+				`Using fallback value 'preview_urls = ${wantPreviews}'.`,
+			].join("\n")
+		);
+	}
+
 	// workers.dev URL is only set if we want to deploy to workers.dev.
 
 	let workersDevURL: string | undefined;