Skip to content

Commit a3d9d64

Browse files
authored
add label customisation (#8284)
1 parent a9c0159 commit a3d9d64

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

.github/workflows/hotfix-release.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ on:
99
description: "Confirm that the PR is up to date with the last published release, with the specific additional changes that should be released as part of this hotfix and the relevant package patch versions bumped"
1010
type: boolean
1111
required: true
12-
prerelease:
13-
description: "Publish to the hotfix tag on NPM for testing?"
14-
type: boolean
12+
label:
13+
description: "Which dist-tag should this release have?"
14+
type: string
15+
default: hotfix
1516
required: true
1617
jobs:
1718
hotfix-release:
18-
name: Create Draft PR
19+
name: Hotfix Release
1920
if: ${{ inputs.confirm == true }}
2021
runs-on: ubuntu-latest
2122
steps:
@@ -56,10 +57,5 @@ jobs:
5657
env:
5758
CI_OS: ${{ runner.os }}
5859

59-
- name: Publish packages (prerelease)
60-
if: ${{ inputs.prerelease == true }}
61-
run: pnpm publish -r --tag hotfix --filter wrangler --filter miniflare --filter create-cloudflare --dry-run
62-
6360
- name: Publish packages
64-
if: ${{ inputs.prerelease == false }}
65-
run: pnpm publish -r --filter wrangler --filter miniflare --filter create-cloudflare --dry-run
61+
run: pnpm publish -r --tag ${{ inputs.label }} --filter wrangler --filter miniflare --filter create-cloudflare --dry-run

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,6 +446,7 @@ If a hotfix release of Wrangler, Miniflare, or C3 is required, you should:
446446

447447
- Get approvals for that PR, and make sure CI checks are passing
448448
- Manually trigger a hotfix release from that PR using the ["Release a hotfix"](https://github.com/cloudflare/workers-sdk/actions/workflows/hotfix-release.yml) GitHub action.
449-
- Optionally, you can first publish it to the `hotfix` tag on NPM in order to verify the release.
449+
- Make sure you set the dist-tag to `latest`
450+
- Optionally, you can first publish it to the `hotfix` dist-tag on NPM in order to verify the release.
450451
- **[CRUCIAL]** Once the hotfix release is out and verified, merge the fixes into main before the next regular release of `workers-sdk`.
451452
- Make sure that the version number of the next changesets-based release of Wrangler/Miniflare/C3 is greater than the version used for the hotfix by adding a dummy `minor` changeset entry for each of the packages that had a hotfix published.

0 commit comments

Comments
 (0)