staging wrangler should push images to staging.registry.cloudflare.com (#10808)

Author: nikitassharma

.changeset/open-birds-argue.md

@@ -0,0 +1,7 @@
+---
+"@cloudflare/containers-shared": patch
+---
+
+When returning the default managed registry, inspect the environment variable
+`WRANGLER_API_ENVIRONMENT` to determine if we should be returning the production
+or staging registry.

packages/containers-shared/src/knobs.ts

@@ -1,9 +1,16 @@
 import { MF_DEV_CONTAINER_PREFIX } from "./registry";
 
-// default cloudflare managed registry, can be overriden with the env var - CLOUDFLARE_CONTAINER_REGISTRY
+// Will return the default cloudflare managed registry for either a staging or production envrionment
+// based on the env var WRANGLER_API_ENVIRONMENT. The default registry can be overriden with the env
+// var CLOUDFLARE_CONTAINER_REGISTRY.
 export const getCloudflareContainerRegistry = () => {
 	// previously defaulted to registry.cloudchamber.cfdata.org
-	return process.env.CLOUDFLARE_CONTAINER_REGISTRY ?? "registry.cloudflare.com";
+	return (
+		process.env.CLOUDFLARE_CONTAINER_REGISTRY ??
+		(process.env.WRANGLER_API_ENVIRONMENT === "staging"
+			? "staging.registry.cloudflare.com"
+			: "registry.cloudflare.com")
+	);
 };
 
 /**

packages/containers-shared/tests/knobs.test.ts

@@ -0,0 +1,16 @@
+import { getCloudflareContainerRegistry } from "./../src/knobs";
+
+describe("getCloudflareContainerRegistry", () => {
+	it("should return the managed registry", () => {
+		expect(getCloudflareContainerRegistry()).toBe("registry.cloudflare.com");
+		vi.stubEnv("WRANGLER_API_ENVIRONMENT", "production");
+		expect(getCloudflareContainerRegistry()).toBe("registry.cloudflare.com");
+	});
+
+	it("should return the staging registry", () => {
+		vi.stubEnv("WRANGLER_API_ENVIRONMENT", "staging");
+		expect(getCloudflareContainerRegistry()).toBe(
+			"staging.registry.cloudflare.com"
+		);
+	});
+});

turbo.json

@@ -12,7 +12,8 @@
 		"TEST_REPORT_PATH",
 		"CLOUDFLARE_CONTAINER_REGISTRY",
 		"DOCKER_HOST",
-		"WRANGLER_DOCKER_HOST"
+		"WRANGLER_DOCKER_HOST",
+		"WRANGLER_API_ENVIRONMENT"
 	],
 	"tasks": {
 		"dev": {