Skip to content

Commit aae4e2b

Browse files
TO_REMOVE: try to run vite e2e test on node 24
1 parent fa36841 commit aae4e2b

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

.github/workflows/e2e.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
node: 20.19.1
102102
- os: windows-2022
103103
description: v20, Windows
104-
node: 20.19.1
104+
node: 24
105105
# we need to use an amd image to run the containers tests, since we build for linux/amd64
106106
- os: ubuntu-24.04
107107
description: v20, Linux

packages/vite-plugin-cloudflare/e2e/remote-bindings.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,7 @@ describe("remote bindings disabled", () => {
143143
const projectPath = seed("remote-bindings-disabled", "pnpm");
144144

145145
describe.each(commands)('with "%s" command', (command) => {
146-
// On Windows the path for the miniflare dependency gets pretty long and this fails in node < 22.7
147-
// (see: https://github.com/shellscape/jsx-email/issues/225#issuecomment-2420567832), so
148-
// we need to skip this on windows since in CI we're using node 20
149-
// we should look into re-enable this once we can move to a node a newer version of node
150-
test.skipIf(process.platform === "win32")(
146+
test.skipIf(false)(
151147
"cannot connect to remote bindings",
152148
async ({ expect }) => {
153149
const proc = await runLongLived("pnpm", command, projectPath);

0 commit comments

Comments
 (0)