add warning for when users run wrangler dev --remote with (enabled) containers (#9976)

* add warning for when users run `wrangler dev --remote` with (enabled) containers

* remove incorrect @inheritable tag from dev.enable_containers config

Author: dario-piotrowicz

.changeset/tidy-plants-dance.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+add warning for when users run `wrangler dev --remote` with (enabled) containers

packages/wrangler/src/__tests__/dev.test.ts

@@ -37,6 +37,13 @@ vi.mock("../api/startDevWorker/ConfigController", (importOriginal) =>
 
 vi.mock("../dev/hotkeys");
 
+vi.mock("@cloudflare/containers-shared", async (importOriginal) => {
+	return {
+		...(await importOriginal()),
+		isDockerfile: () => true,
+	};
+});
+
 // Don't memoize in tests. If we did, it would memoize across test runs, which causes problems
 vi.mock("../utils/memoizeGetPort", () => {
 	return {
@@ -1782,6 +1789,59 @@ describe.sequential("wrangler dev", () => {
 			expect(std.warn).toMatchInlineSnapshot(`""`);
 		});
 	});
+
+	describe("containers", () => {
+		it("should warn when run in remote mode with (enabled) containers", async () => {
+			writeWranglerConfig({
+				main: "index.js",
+				compatibility_date: "2024-01-01",
+				containers: [
+					{
+						class_name: "ContainerClass",
+						image: "./Dockerfile",
+					},
+				],
+			});
+			fs.writeFileSync("index.js", `export default {};`);
+
+			await expect(
+				runWrangler("dev --remote")
+			).rejects.toThrowErrorMatchingInlineSnapshot(
+				"[Error: Bailing early in tests]"
+			);
+
+			expect(std.warn).toMatchInlineSnapshot(`
+				"▲ [WARNING] Containers are only supported in local mode, to suppress this warning set \`dev.enable_containers\` to \`false\` or pass \`--enable-containers=false\` to the \`wrangler dev\` command
+
+				"
+			`);
+		});
+
+		it("should not warn when run in remote mode with disabled containers", async () => {
+			writeWranglerConfig({
+				main: "index.js",
+				compatibility_date: "2024-01-01",
+				containers: [
+					{
+						class_name: "ContainerClass",
+						image: "./Dockerfile",
+					},
+				],
+				dev: {
+					enable_containers: false,
+				},
+			});
+			fs.writeFileSync("index.js", `export default {};`);
+
+			await expect(
+				runWrangler("dev --remote")
+			).rejects.toThrowErrorMatchingInlineSnapshot(
+				"[Error: Bailing early in tests]"
+			);
+
+			expect(std.warn).toMatchInlineSnapshot(`""`);
+		});
+	});
 });
 
 function mockGetZones(domain: string, zones: { id: string }[] = []) {

packages/wrangler/src/api/startDevWorker/ConfigController.ts

@@ -416,15 +416,29 @@ async function resolveConfig(
 		logger.warn("Queues are not yet supported in wrangler dev remote mode.");
 	}
 
-	// TODO(do) support remote wrangler dev
-	const classNamesWhichUseSQLite = getClassNamesWhichUseSQLite(
-		resolved.migrations
-	);
-	if (
-		resolved.dev.remote &&
-		Array.from(classNamesWhichUseSQLite.values()).some((v) => v)
-	) {
-		logger.warn("SQLite in Durable Objects is only supported in local mode.");
+	if (resolved.dev.remote) {
+		// We're in remote mode (`--remote`)
+
+		if (
+			resolved.dev.enableContainers &&
+			resolved.containers &&
+			resolved.containers.length > 0
+		) {
+			logger.warn(
+				"Containers are only supported in local mode, to suppress this warning set `dev.enable_containers` to `false` or pass `--enable-containers=false` to the `wrangler dev` command"
+			);
+		}
+
+		// TODO(do) support remote wrangler dev
+		const classNamesWhichUseSQLite = getClassNamesWhichUseSQLite(
+			resolved.migrations
+		);
+		if (
+			resolved.dev.remote &&
+			Array.from(classNamesWhichUseSQLite.values()).some((v) => v)
+		) {
+			logger.warn("SQLite in Durable Objects is only supported in local mode.");
+		}
 	}
 
 	// prompt user to update their types if we detect that it is out of date

packages/wrangler/src/config/config.ts

@@ -238,7 +238,6 @@ export interface DevConfig {
 	 * When developing, whether to build and connect to containers. This requires a Docker daemon to be running.
 	 * Defaults to `true`.
 	 *
-	 * @inheritable
 	 * @default true
 	 */
 	enable_containers: boolean;