Skip to content

Commit b2dca9a

Browse files
authored
feat: add some logging when no bindings are found (#8028)
* log no bindings found * changeset * Update sharp-carrots-deliver.md
1 parent e62b097 commit b2dca9a

File tree

8 files changed

+205
-44
lines changed

8 files changed

+205
-44
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"wrangler": minor
3+
---
4+
5+
feat: Also log when _no_ bindings are found.
6+
7+
We currently print a worker's bindings during dev, versions upload and deploy. This just also prints something when there's no bindings found, in case you _were_ expecting bindings.

packages/wrangler/e2e/deployments.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ Uploaded 2 of 3 assets
272272
Uploaded 3 of 3 assets
273273
✨ Success! Uploaded 3 files (TIMINGS)
274274
Total Upload: xx KiB / gzip: xx KiB
275+
No bindings found.
275276
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
276277
Deployed tmp-e2e-worker-00000000-0000-0000-0000-000000000000 triggers (TIMINGS)
277278
https://tmp-e2e-worker-00000000-0000-0000-0000-000000000000.SUBDOMAIN.workers.dev
@@ -282,6 +283,7 @@ Current Version ID: 00000000-0000-0000-0000-000000000000`);
282283
🌀 Starting asset upload...
283284
No files to upload. Proceeding with deployment...
284285
Total Upload: xx KiB / gzip: xx KiB
286+
No bindings found.
285287
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
286288
Deployed tmp-e2e-worker-00000000-0000-0000-0000-000000000000 triggers (TIMINGS)
287289
https://tmp-e2e-worker-00000000-0000-0000-0000-000000000000.SUBDOMAIN.workers.dev
@@ -342,6 +344,7 @@ Uploaded 2 of 3 assets
342344
Uploaded 3 of 3 assets
343345
✨ Success! Uploaded 3 files (TIMINGS)
344346
Total Upload: xx KiB / gzip: xx KiB
347+
No bindings found.
345348
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
346349
Dispatch Namespace: tmp-e2e-dispatch-00000000-0000-0000-0000-000000000000
347350
Current Version ID: 00000000-0000-0000-0000-000000000000`);
@@ -351,6 +354,7 @@ Current Version ID: 00000000-0000-0000-0000-000000000000`);
351354
🌀 Starting asset upload...
352355
No files to upload. Proceeding with deployment...
353356
Total Upload: xx KiB / gzip: xx KiB
357+
No bindings found.
354358
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
355359
Dispatch Namespace: tmp-e2e-dispatch-00000000-0000-0000-0000-000000000000
356360
Current Version ID: 00000000-0000-0000-0000-000000000000`);

packages/wrangler/e2e/versions.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ describe("versions deploy", { timeout: TIMEOUT }, () => {
6464
expect(normalize(upload.stdout)).toMatchInlineSnapshot(`
6565
"Total Upload: xx KiB / gzip: xx KiB
6666
Worker Startup Time: (TIMINGS)
67+
No bindings found.
6768
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
6869
Worker Version ID: 00000000-0000-0000-0000-000000000000
6970
Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
@@ -180,6 +181,7 @@ describe("versions deploy", { timeout: TIMEOUT }, () => {
180181
expect(normalize(upload.stdout)).toMatchInlineSnapshot(`
181182
"Total Upload: xx KiB / gzip: xx KiB
182183
Worker Startup Time: (TIMINGS)
184+
No bindings found.
183185
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
184186
Worker Version ID: 00000000-0000-0000-0000-000000000000
185187
Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev
@@ -614,6 +616,7 @@ describe("versions deploy", { timeout: TIMEOUT }, () => {
614616
✨ Success! Uploaded 1 file (TIMINGS)
615617
Total Upload: xx KiB / gzip: xx KiB
616618
Worker Startup Time: (TIMINGS)
619+
No bindings found.
617620
Uploaded tmp-e2e-worker-00000000-0000-0000-0000-000000000000 (TIMINGS)
618621
Worker Version ID: 00000000-0000-0000-0000-000000000000
619622
Version Preview URL: https://tmp-e2e-worker-PREVIEW-URL.SUBDOMAIN.workers.dev

0 commit comments

Comments
 (0)