Skip to content

Commit b46386c

Browse files
Very minor containers cleanups/improvements (#9925)
* clarify docker build error message * make containers.dev e2e build test runnable even without an account id * update wrong class name in worker-configuration.d.ts * remove unnecessary catch params
1 parent 3bb69fa commit b46386c

File tree

5 files changed

+251
-243
lines changed

5 files changed

+251
-243
lines changed

.changeset/hot-rice-read.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cloudflare/containers-shared": patch
3+
---
4+
5+
clarify the docker build error message
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
declare namespace Cloudflare {
22
interface Env {
3-
CONTAINER: DurableObjectNamespace<import("./src").Container>;
3+
CONTAINER: DurableObjectNamespace<import("./src").FixtureTestContainer>;
44
}
55
}
66
interface Env extends Cloudflare.Env {}

packages/containers-shared/src/build.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export function dockerBuild(
6969
resolve();
7070
} else if (!errorHandled) {
7171
errorHandled = true;
72-
reject(new Error(`Build exited with code: ${code}`));
72+
reject(new Error(`Docker build exited with code: ${code}`));
7373
}
7474
});
7575
child.on("error", (err) => {

packages/containers-shared/src/images.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export function resolveImageName(accountId: string, image: string): string {
118118
let url: URL;
119119
try {
120120
url = new URL(`http://${image}`);
121-
} catch (_) {
121+
} catch {
122122
return image;
123123
}
124124

0 commit comments

Comments
 (0)