V3 Backport [#9257]: Revert R2 bucket validation for commands (#9259)

* revert R2 bucket validation for pages dev

* add changeset

* Update packages/wrangler/src/pages/dev.ts

Co-authored-by: Victor Berchet <[email protected]>

* format

---------

Co-authored-by: Samuel Macleod <[email protected]>
Co-authored-by: Victor Berchet <[email protected]>

Author: 3 people

.changeset/great-berries-grow.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Relax R2 bucket validation for `pages dev` commands

packages/wrangler/e2e/pages-dev.test.ts

@@ -115,7 +115,7 @@ describe.sequential.each([{ cmd: "wrangler pages dev" }])(
 					}`,
 			});
 			const worker = helper.runLongLived(
-				`${cmd} --inspector-port ${inspectorPort} . --port ${port} --service TEST_SERVICE=test-worker --kv TEST_KV --do TEST_DO=TestDurableObject@a --d1 TEST_D1 --r2 test-r2`
+				`${cmd} --inspector-port ${inspectorPort} . --port ${port} --service TEST_SERVICE=test-worker --kv TEST_KV --do TEST_DO=TestDurableObject@a --d1 TEST_D1 --r2 TEST_R2`
 			);
 			await worker.waitForReady();
 			expect(normalizeOutput(worker.currentOutput)).toContain(
@@ -127,7 +127,7 @@ describe.sequential.each([{ cmd: "wrangler pages dev" }])(
 					- D1 Databases:
 					  - TEST_D1: local-TEST_D1 (TEST_D1) [simulated locally]
 					- R2 Buckets:
-					  - test-r2: test-r2 [simulated locally]
+					  - TEST_R2: TEST_R2 [simulated locally]
 					- Services:
 					  - TEST_SERVICE: test-worker [not connected]
 		`

packages/wrangler/src/pages/dev.ts

@@ -16,7 +16,6 @@ import { logger } from "../logger";
 import * as metrics from "../metrics";
 import { isNavigatorDefined } from "../navigator-user-agent";
 import { getBasePath } from "../paths";
-import { bucketFormatMessage, isValidR2BucketName } from "../r2/helpers";
 import * as shellquote from "../utils/shell-quote";
 import { printWranglerBanner } from "../wrangler-banner";
 import { buildFunctions } from "./buildFunctions";
@@ -1273,15 +1272,8 @@ function getBindingsFromArgs(args: PagesDevArguments): Partial<
 					return;
 				}
 
-				const bucketName = ref || binding.toString();
-
-				if (!isValidR2BucketName(bucketName)) {
-					logger.error(
-						`The bucket name "${bucketName}" is invalid. ${bucketFormatMessage}`
-					);
-					return;
-				}
-
+				// The generated `bucket_name` might be invalid as per https://developers.cloudflare.com/r2/buckets/create-buckets/#bucket-level-operations
+				// However this name only applies to the dev environment and is not validated by miniflare.
 				return { binding, bucket_name: ref || binding.toString() };
 			})
 			.filter(Boolean) as EnvironmentNonInheritable["r2_buckets"];