Fix asset-worker analytics not sending on success (#8017)

WalshyDev · web-flow · commit b9805d7721f7 · 2025-02-04T15:46:13.000Z
diff --git a/packages/workers-shared/asset-worker/src/index.ts b/packages/workers-shared/asset-worker/src/index.ts
@@ -123,9 +123,9 @@ export default class extends WorkerEntrypoint<Env> {
 				);
 			});
 		} catch (err) {
-			const errorResponse = this.handleError(sentry, analytics, err);
+			return this.handleError(sentry, analytics, err);
+		} finally {
 			this.submitMetrics(analytics, performance, startTimeMs);
-			return errorResponse;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -123,9 +123,9 @@ export default class extends WorkerEntrypoint<Env> {`
`123`	`123`	`);`
`124`	`124`	`});`
`125`	`125`	`} catch (err) {`
`126`		`- const errorResponse = this.handleError(sentry, analytics, err);`
	`126`	`+ return this.handleError(sentry, analytics, err);`
	`127`	`+ } finally {`
`127`	`128`	`this.submitMetrics(analytics, performance, startTimeMs);`
`128`		`- return errorResponse;`
`129`	`129`	`}`
`130`	`130`	`}`
`131`	`131`