fix: make wrangler deploy not call Workflows API if it binds to a different script (#7964)

Basically, if a worker bounds to a Workflow defined in another script,
it would do a PUT call to the Workflow API, overriding the config and
because it would change the `script_name`, it would break new instances
(because this one will probably not have the class exported).

This commit makes it so that Wrangler does not call the API if the
`script_name` is different.

Author: LuisDuarte1

.changeset/poor-hornets-exercise.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix scripts binding to a workflow in a different script overriding workflow config

packages/wrangler/src/__tests__/deploy.test.ts

@@ -12347,6 +12347,66 @@ export default{
 				Current Version ID: Galaxy-Class"
 			`);
 		});
+
+		it("should not call Workflow's API if the workflow binds to another script", async () => {
+			writeWranglerConfig({
+				main: "index.js",
+				name: "this-script",
+				workflows: [
+					{
+						binding: "WORKFLOW",
+						name: "my-workflow",
+						class_name: "MyWorkflow",
+						script_name: "another-script",
+					},
+				],
+			});
+
+			mockSubDomainRequest();
+			mockUploadWorkerRequest({
+				expectedScriptName: "this-script",
+				expectedBindings: [
+					{
+						type: "workflow",
+						name: "WORKFLOW",
+						workflow_name: "my-workflow",
+						class_name: "MyWorkflow",
+						script_name: "another-script",
+					},
+				],
+			});
+
+			const handler = http.put(
+				"*/accounts/:accountId/workflows/:workflowName",
+				() => {
+					expect(
+						false,
+						"Workflows API should not be called at all, in this case."
+					);
+				}
+			);
+			msw.use(handler);
+			await fs.promises.writeFile(
+				"index.js",
+				`
+                export default {};
+            `
+			);
+
+			await runWrangler("deploy");
+
+			expect(std.out).toMatchInlineSnapshot(`
+				"Total Upload: xx KiB / gzip: xx KiB
+				Worker Startup Time: 100 ms
+				Your worker has access to the following bindings:
+				- Workflows:
+				  - WORKFLOW: MyWorkflow (defined in another-script)
+				Uploaded this-script (TIMINGS)
+				Deployed this-script triggers (TIMINGS)
+				  https://this-script.test-sub-domain.workers.dev
+				Current Version ID: Galaxy-Class"
+			`);
+		});
 	});
 });
 

packages/wrangler/src/triggers/deploy.ts

@@ -256,6 +256,15 @@ export default async function triggersDeploy(
 		logger.once.warn("Workflows is currently in open beta.");
 
 		for (const workflow of config.workflows) {
+			// NOTE: if the user provides a script_name thats not this script (aka bounds to another worker)
+			// we don't want to send this worker's config.
+			if (
+				workflow.script_name !== undefined &&
+				workflow.script_name !== scriptName
+			) {
+				continue;
+			}
+
 			deployments.push(
 				fetchResult(`/accounts/${accountId}/workflows/${workflow.name}`, {
 					method: "PUT",