Don't require Hyperdrive local connection string when using wrangler dev --remote (#7485)

* Don't require Hyperdrive local connection string when using wrangler dev --remote

* Add changeset

* Fix style issues

* fix type issue

Author: mtlemilio

.changeset/nervous-jeans-obey.md

@@ -0,0 +1,5 @@
+---
+"wrangler": patch
+---
+
+Fix to not require local connection string when using Hyperdrive and wrangler dev --remote

packages/wrangler/e2e/dev.test.ts

@@ -555,6 +555,49 @@ describe("hyperdrive dev tests", () => {
 		await socketMsgPromise;
 	});
 
+	it("does not require local connection string when running `wrangler dev --remote`", async () => {
+		const helper = new WranglerE2ETestHelper();
+		await helper.seed({
+			"wrangler.toml": dedent`
+					name = "${workerName}"
+					main = "src/index.ts"
+					compatibility_date = "2023-10-25"
+
+					[[hyperdrive]]
+					binding = "HYPERDRIVE"
+					id = "hyperdrive_id"
+			`,
+			"src/index.ts": dedent`
+					export default {
+						async fetch(request, env) {
+							if (request.url.includes("connect")) {
+								const conn = env.HYPERDRIVE.connect();
+								await conn.writable.getWriter().write(new TextEncoder().encode("test string"));
+							}
+							return new Response(env.HYPERDRIVE?.connectionString ?? "no")
+						}
+					}`,
+			"package.json": dedent`
+					{
+						"name": "worker",
+						"version": "0.0.0",
+						"private": true
+					}
+					`,
+		});
+
+		const worker = helper.runLongLived("wrangler dev --remote");
+
+		const { url } = await worker.waitForReady();
+		const text = await fetchText(url);
+
+		const hyperdrive = new URL(text);
+		expect(hyperdrive.pathname).toBe("/some_db");
+		expect(hyperdrive.username).toBe("user");
+		expect(hyperdrive.password).toBe("!pass");
+		expect(hyperdrive.host).not.toBe("localhost");
+	});
+
 	afterEach(() => {
 		if (server.listening) {
 			server.close();

packages/wrangler/src/dev.ts

@@ -1042,7 +1042,12 @@ export function getBindings(
 			process.env[
 				`WRANGLER_HYPERDRIVE_LOCAL_CONNECTION_STRING_${hyperdrive.binding}`
 			];
-		if (!connectionStringFromEnv && !hyperdrive.localConnectionString) {
+		// only require a local connection string in the wrangler file or the env if not using dev --remote
+		if (
+			local &&
+			!connectionStringFromEnv &&
+			!hyperdrive.localConnectionString
+		) {
 			throw new UserError(
 				`When developing locally, you should use a local Postgres connection string to emulate Hyperdrive functionality. Please setup Postgres locally and set the value of the 'WRANGLER_HYPERDRIVE_LOCAL_CONNECTION_STRING_${hyperdrive.binding}' variable or "${hyperdrive.binding}"'s "localConnectionString" to the Postgres connection string.`
 			);