fix(create-cloudflare): Ensure we exit the process on "SIGINT" and "SIGTERM" (#8243)

Currently C3 does not explicitly exit the process if an error is
thrown, or if a "SIGINT" or "SIGTERM" signal is received. This leads
to situations when, if `ctrl+C` is pressed while there are still
tasks in the stack/microtask queues (think in flight async xhr calls,
or polling, or long running `while` loops), the current process will
continue running until all those tasks are run to completion, and
the queues are empty.

This commit fixes this by explicitly calling `process.exit()` when
an error is thrown (our internal "SIGINT"/"SIGTERM" handlers  will
throw a `CancelError`), thus ensuring we always exit the process.

Author: CarmenPopoviciu

.changeset/ripe-socks-stay.md

@@ -0,0 +1,10 @@
+---
+"create-cloudflare": patch
+---
+
+fix: Ensure we exit the process on "SIGINT" and "SIGTERM"
+
+Currently C3 does not explicitly exit the process if an error is thrown, or if a "SIGINT" or "SIGTERM" signal is received. This leads to situations when, if `ctrl+C` is pressed while there are still tasks in the stack/microtask queues (think in flight async xhr calls, or polling, or long running
+`while` loops), the current process will continue running until all those tasks are run to completion, and the queues are empty.
+
+This commit fixes this by explicitly calling `process.exit()` when an error is thrown (our internal "SIGINT"/"SIGTERM" handlers will throw a `CancelError`), thus ensuring we always exit the process.

packages/create-cloudflare/src/cli.ts

@@ -201,4 +201,9 @@ main(process.argv)
 	})
 	.finally(async () => {
 		await reporter.waitForAllEventsSettled();
+
+		// ensure we explicitly exit the process, otherwise any ongoing async
+		// calls or leftover tasks in the stack queue will keep running until
+		// completed
+		process.exit();
 	});

packages/create-cloudflare/src/metrics.ts

@@ -188,7 +188,7 @@ export function createReporter() {
 		// Create a new promise that will reject when the user interrupts the process
 		const cancelDeferred = promiseWithResolvers<never>();
 		const cancel = async (signal?: NodeJS.Signals) => {
-			// Let subtasks handles the signals first with a short timeout
+			// Let subtasks handle the signals first with a short timeout
 			await setTimeout(10);
 
 			cancelDeferred.reject(new CancelError(`Operation cancelled`, signal));